Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Display required badge in custom field configuration. #171975

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[Cases] Display required badge in custom field configuration. #171975

merged 1 commit into from
Nov 27, 2023

Conversation

adcoelho
Copy link
Contributor

Fixes #167767

Summary

I added information about whether the custom field is required or not.

Additionally, I followed @mdefazio 's comment and changed how we display these to use anEuiBadge instead. The color is custom.

Screenshot 2023-11-27 at 11 57 52

@adcoelho adcoelho added enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.12.0 labels Nov 27, 2023
@adcoelho adcoelho self-assigned this Nov 27, 2023
@adcoelho adcoelho requested a review from a team as a code owner November 27, 2023 11:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@adcoelho
Copy link
Contributor Author

I messed up and deleted @mdefazio comment on this issue by mistake 😅

Luckily I had it cached and took a print screen.

Screenshot 2023-11-27 at 11 12 41

I have a PR for the EuiBadge change. I am trying to change the hover behaviour but it requires changing Lots of tests so it will come on a separate PR.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 448.1KB 448.3KB +229.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

js-jankisalvi
js-jankisalvi approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@adcoelho adcoelho merged commit 5f5c92a into elastic:main Nov 27, 2023
11 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees

@adcoelho adcoelho

Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] Add required to custom field description in settings page
5 participants
@adcoelho @elasticmachine @kibana-ci @js-jankisalvi @kibanamachine