Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Add required to custom field description in settings page #167767

Closed
adcoelho opened this issue Oct 2, 2023 · 3 comments · Fixed by #171975
Closed

[Cases] Add required to custom field description in settings page #167767

adcoelho opened this issue Oct 2, 2023 · 3 comments · Fixed by #171975
Assignees
@adcoelho
Labels
enhancement New value added to drive a business result Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@adcoelho
Copy link
Contributor

adcoelho commented Oct 2, 2023 •
edited by cnasikas
Loading

Summary

For the new custom fields feature, it is not immediately apparent on the settings page if a custom field is required.

Screenshot 2023-10-02 at 13 46 18

We already display the custom field type, maybe we could also show whether or not a custom field is required or not.

ping @mdefazio
@adcoelho adcoelho added enhancement New value added to drive a business result Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Oct 2, 2023
@adcoelho adcoelho self-assigned this Oct 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl
Copy link
Contributor

lcawl commented Oct 3, 2023

I agree that if we can callout only the "Required" items that's cleaner than putting "Required" and "Optional" on every one.

@elastic elastic deleted a comment from mdefazio Nov 27, 2023
@adcoelho adcoelho mentioned this issue Nov 27, 2023
Merged
kibanamachine pushed a commit to fkanout/kibana that referenced this issue Nov 27, 2023
@adcoelho
[Cases] Display required badge in custom field configuration. (elasti…
5f5c92a 
…c#171975)

Fixes elastic#167767

## Summary

I added information about whether the custom field is required or not.

Additionally, I followed @mdefazio 's comment and changed how we display
these to use an`EuiBadge` instead. The color is custom.

<img width="1207" alt="Screenshot 2023-11-27 at 11 57 52"
src="https://github.com/elastic/kibana/assets/1533137/4c491293-1ccf-4377-843f-55fef45fc9b3">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
enhancement New value added to drive a business result Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Display required badge in custom field configuration. adcoelho/kibana
3 participants
@adcoelho @elasticmachine @lcawl