Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] Fixes CCR accessibility tests #171618

Merged
merged 10 commits into from
Nov 23, 2023
Merged

[CCR] Fixes CCR accessibility tests #171618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d21ad4
Fix flaky tests
sabarasaba Nov 20, 2023
8cb8921
commit with @elastic email
sabarasaba Nov 20, 2023
6c0bfda
Merge branch 'main' into ccr-fix_flaky_tests
kibanamachine Nov 20, 2023
e7e9e7c
Resetup flaky test
sabarasaba Nov 21, 2023
df31e24
Move tests around
sabarasaba Nov 21, 2023
65cf2b2
Skip test
sabarasaba Nov 21, 2023
cd7b051
Merge branch 'main' into ccr-fix_flaky_tests
kibanamachine Nov 21, 2023
d43d013
Merge branch 'main' into ccr-fix_flaky_tests
kibanamachine Nov 21, 2023
504a7c9
Merge branch 'main' into ccr-fix_flaky_tests
kibanamachine Nov 22, 2023
07de1a8
Merge branch 'main' into ccr-fix_flaky_tests
kibanamachine Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,7 @@ describe('<FollowerIndicesList />', () => {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/100951
describe.skip('detail panel', () => {
describe('detail panel', () => {
test('should open a detail panel when clicking on a follower index', async () => {
expect(exists('followerIndexDetail')).toBe(false);

Expand Down Expand Up @@ -372,7 +371,8 @@ describe('<FollowerIndicesList />', () => {
);
});

test('should have a section to render the follower index shards stats', async () => {
// FLAKY: https://github.com/elastic/kibana/issues/100951
test.skip('should have a section to render the follower index shards stats', async () => {
await actions.clickFollowerIndexAt(0);
expect(exists('followerIndexDetail.shardsStatsSection')).toBe(true);

Expand Down
3 changes: 3 additions & 0 deletions ...sters/public/application/sections/components/remote_cluster_setup_trust/confirm_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ export const ConfirmTrustSetupModal = ({ closeModal, onSubmit }: ModalProps) =>
label={i18n.translate('xpack.remoteClusters.clusterWizard.trustStep.modal.checkbox', {
defaultMessage: 'Yes, I have setup trust',
})}
labelProps={{
'data-test-subj': 'remoteClusterTrustCheckboxLabel',
}}
checked={hasSetupTrust}
onChange={() => setHasSetupTrust(!hasSetupTrust)}
data-test-subj="remoteClusterTrustCheckbox"
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/accessibility/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
// CCR tests stay in that order. Their execution fails if rearranged.
require.resolve('./apps/remote_clusters'),
require.resolve('./apps/snapshot_and_restore'),
// https://github.com/elastic/kibana/issues/153599
// require.resolve('./apps/cross_cluster_replication'),
require.resolve('./apps/cross_cluster_replication'),
require.resolve('./apps/reporting'),
require.resolve('./apps/enterprise_search'),
// require.resolve('./apps/license_management'),
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/page_objects/remote_clusters_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function RemoteClustersPageProvider({ getService }: FtrProviderContext) {

// Complete trust setup
await testSubjects.click('setupTrustDoneButton');
await testSubjects.setCheckbox('remoteClusterTrustCheckbox', 'check');
await testSubjects.setCheckbox('remoteClusterTrustCheckboxLabel', 'check');
await testSubjects.click('remoteClusterTrustSubmitButton');
},
async getRemoteClustersList() {
Expand Down
Loading