-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCR] Fixes CCR accessibility tests #171618
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for looking into these tests, @sabarasaba!
The a11y fix LGTM: +1 The flaky jest tests are still a mystery, I think let's try enabling them and if we see any failures again, that might be the same issue as with Index Management and Watcher tests
Thanks for having a look! I've dig through quite a bit on them, and this particular test always seems to fail on CI with the timeout error, just doesnt happen locally (like ever). I havent been able to get a green CI with it so i think better to keep it disabled :( |
Well at least it always fails on CI, that's something :D |
Closes #169512
Summary
This PR fixes the accesibility test for CCR thats currently broken due to using the wrong selector for enabling trust in remote clusters and attempts to fix the flaky test we had in follower indices for a while. I ran it 100 times locally and seems to be green every single time.