Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] Fixes CCR accessibility tests #171618

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Nov 21, 2023

Closes #169512

Summary

This PR fixes the accesibility test for CCR thats currently broken due to using the wrong selector for enabling trust in remote clusters and attempts to fix the flaky test we had in follower indices for a while. I ran it 100 times locally and seems to be green every single time.

@sabarasaba sabarasaba added Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.12.0 labels Nov 21, 2023
@sabarasaba sabarasaba self-assigned this Nov 21, 2023
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
remoteClusters 75.2KB 75.3KB +64.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba changed the title [CCR] Fix flaky test and fixes CCR accessibility tests [CCR] Fixes CCR accessibility tests Nov 23, 2023
@sabarasaba sabarasaba marked this pull request as ready for review November 23, 2023 12:54
@sabarasaba sabarasaba requested a review from a team as a code owner November 23, 2023 12:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into these tests, @sabarasaba!
The a11y fix LGTM: +1 The flaky jest tests are still a mystery, I think let's try enabling them and if we see any failures again, that might be the same issue as with Index Management and Watcher tests

@sabarasaba
Copy link
Member Author

Thanks a lot for looking into these tests, @sabarasaba! The a11y fix LGTM: +1 The flaky jest tests are still a mystery, I think let's try enabling them and if we see any failures again, that might be the same issue as with Index Management and Watcher tests

Thanks for having a look! I've dig through quite a bit on them, and this particular test always seems to fail on CI with the timeout error, just doesnt happen locally (like ever). I havent been able to get a green CI with it so i think better to keep it disabled :(

@yuliacech
Copy link
Contributor

Well at least it always fails on CI, that's something :D

@sabarasaba sabarasaba merged commit 3240ab6 into elastic:main Nov 23, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote Cluster] Test setup for creating a new remote cluster fails
5 participants