Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] [Security Solution][Investigations] - Add check for changing alert status from bulk options (#170584) #170781

Closed

Conversation

michaelolo24
Copy link
Contributor

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

…atus from bulk options (elastic#170584)

## Summary
Addresses elastic#169684

This PR is a re-do of: elastic#169723
(With cypress tests currently skipped until proper role is available).
The alert privileges needs to be added for the alert table as it wasn't
added when the migration took place. An example of the privileges
elsewhere is below:

https://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33

Fix:

https://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 3651571)

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts/alert_status.cy.ts
@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 7, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #25 / Agents fleet_list_agent should return metrics if available and called with withMetrics
  • [job] [logs] FTR Configs #25 / Agents fleet_list_agent should return metrics if available and called with withMetrics
  • [job] [logs] Security Solution Cypress Tests #3 / Alert details expandable flyout right panel overview tab visualizations section should display analyzer and session previews should display analyzer and session previews
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #1 / Artifact pages Trusted applications "before all" hook for "should update Endpoint Policy on Endpoint when adding Trusted application name" "before all" hook for "should update Endpoint Policy on Endpoint when adding Trusted application name"
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #1 / Artifact pages Trusted applications "before all" hook for "should update Endpoint Policy on Endpoint when adding Trusted application name" "before all" hook for "should update Endpoint Policy on Endpoint when adding Trusted application name"
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #2 / Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule"
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #2 / Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule"
  • [job] [logs] Security Solution Cypress Tests #6 / Detection rules, Prebuilt Rules Installation and Update workflow Installation of prebuilt rules package via Fleet should install rules from the Fleet package when user clicks on CTA should install rules from the Fleet package when user clicks on CTA
  • [job] [logs] Security Solution Cypress Tests #6 / Detection rules, Prebuilt Rules Installation and Update workflow Installation of prebuilt rules package via Fleet should install rules from the Fleet package when user clicks on CTA should install rules from the Fleet package when user clicks on CTA
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #5 / Isolate command From manage "before all" hook for "should allow filtering endpoint by Isolated status" "before all" hook for "should allow filtering endpoint by Isolated status"
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #5 / Isolate command From manage "before all" hook for "should allow filtering endpoint by Isolated status" "before all" hook for "should allow filtering endpoint by Isolated status"
  • [job] [logs] Security Solution Cypress Tests #13 / timeline data providers persists timeline when data provider is updated by dragging a field from data grid persists timeline when data provider is updated by dragging a field from data grid
  • [job] [logs] Security Solution Cypress Tests #13 / timeline data providers persists timeline when data provider is updated by dragging a field from data grid persists timeline when data provider is updated by dragging a field from data grid
  • [job] [logs] Jest Tests #9 / When the add exception modal is opened error states when there are exception builder errors submit button is disabled

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.6MB 15.6MB +373.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

CI was triggered for this PR, but this PR targets 8.10 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact #kibana-operations if you believe this is an error.

The following branches are currently considered to be open:

  • main
  • 8.11
  • 7.17

auto-merge was automatically disabled November 9, 2023 13:54

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants