[Security Solution] Serverless, Alert actions present for VIEWER role #169684
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Project:Serverless
Work as part of the Serverless project for its initial release
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Investigations
Security Solution Investigations Team
Comments
stephmilovic
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
michaelolo24
added
the
Team:Threat Hunting:Investigations
MadameSheema
added
the
Team:Detection Engine
|
Updating to |
peluja1012
added
impact:high
michaelolo24
added a commit
that referenced
this issue
Nov 7, 2023
…atus from bulk options (#170584) ## Summary Addresses #169684 This PR is a re-do of: #169723 (With cypress tests currently skipped until proper role is available). The alert privileges needs to be added for the alert table as it wasn't added when the migration took place. An example of the privileges elsewhere is below: https://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33 Fix: https://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f --------- Co-authored-by: Kibana Machine <[email protected]>
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this issue
Nov 7, 2023
…atus from bulk options (elastic#170584) ## Summary Addresses elastic#169684 This PR is a re-do of: elastic#169723 (With cypress tests currently skipped until proper role is available). The alert privileges needs to be added for the alert table as it wasn't added when the migration took place. An example of the privileges elsewhere is below: https://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33 Fix: https://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 3651571) # Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts/alert_status.cy.ts
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this issue
Nov 7, 2023
…atus from bulk options (elastic#170584) ## Summary Addresses elastic#169684 This PR is a re-do of: elastic#169723 (With cypress tests currently skipped until proper role is available). The alert privileges needs to be added for the alert table as it wasn't added when the migration took place. An example of the privileges elsewhere is below: https://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33 Fix: https://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 3651571) # Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts/alert_status.cy.ts
michaelolo24
referenced
this issue
Nov 9, 2023
…lert status from bulk options (#170584) (#170780) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution][Investigations] - Add check for changing alert status from bulk options (#170584)](#170584) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Olorunnisola","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-07T17:01:23Z","message":"[Security Solution][Investigations] - Add check for changing alert status from bulk options (#170584)\n\n## Summary\r\nAddresses https://github.com/elastic/kibana/issues/169684\r\n\r\nThis PR is a re-do of: https://github.com/elastic/kibana/pull/169723\r\n(With cypress tests currently skipped until proper role is available).\r\nThe alert privileges needs to be added for the alert table as it wasn't\r\nadded when the migration took place. An example of the privileges\r\nelsewhere is below:\r\n\r\nhttps://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33\r\n\r\n\r\nFix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"36515713a69f6021db8b959b95f7a8ff851b0aa7","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.12.0","v8.11.1","v8.10.5"],"number":170584,"url":"https://github.com/elastic/kibana/pull/170584","mergeCommit":{"message":"[Security Solution][Investigations] - Add check for changing alert status from bulk options (#170584)\n\n## Summary\r\nAddresses https://github.com/elastic/kibana/issues/169684\r\n\r\nThis PR is a re-do of: https://github.com/elastic/kibana/pull/169723\r\n(With cypress tests currently skipped until proper role is available).\r\nThe alert privileges needs to be added for the alert table as it wasn't\r\nadded when the migration took place. An example of the privileges\r\nelsewhere is below:\r\n\r\nhttps://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33\r\n\r\n\r\nFix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"36515713a69f6021db8b959b95f7a8ff851b0aa7"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170584","number":170584,"mergeCommit":{"message":"[Security Solution][Investigations] - Add check for changing alert status from bulk options (#170584)\n\n## Summary\r\nAddresses https://github.com/elastic/kibana/issues/169684\r\n\r\nThis PR is a re-do of: https://github.com/elastic/kibana/pull/169723\r\n(With cypress tests currently skipped until proper role is available).\r\nThe alert privileges needs to be added for the alert table as it wasn't\r\nadded when the migration took place. An example of the privileges\r\nelsewhere is below:\r\n\r\nhttps://github.com/elastic/kibana/blob/75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/use_alerts_actions.tsx#L33\r\n\r\n\r\nFix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/7b354906-9b96-4ba8-b30f-4080cf7e7c2f\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"36515713a69f6021db8b959b95f7a8ff851b0aa7"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
|
@peluja1012 this was fixed on main when this merged: #170584 and will be on 8.11.1. Are we okay to close this now? |
|
Confirmed the fix on serverless prod - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
Alert actions are present for the viewer role
Steps to reproduce:
Be a viewer, go to alerts, check an alert, go to "Selected Alerts"
Current behavior:
Open, close, ack, and alert tags are all available
Expected behavior:
Open, close, ack, and alert tags should be hidden
Screenshots:
The text was updated successfully, but these errors were encountered: