Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Add number formatting to the indices list #170017

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

yuliacech
Copy link
Contributor

Summary

Fixes #22173
This PR adds a formatting to the index size column of the indices list. The number formatting is done according to the default locale in the browser. I decided against aligning the column right because this would looked misaligned to other columns. And aligning all of the columns right doesn't look good either (see screenshots).

Screenshot

Formatted index size

Screenshot 2023-10-27 at 13 32 42

Aligning the size column right (not implemented)

Screenshot 2023-10-27 at 13 34 18

Aligning all columns right (not implemented)

Screenshot 2023-10-27 at 13 34 42

Checklist

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Oct 27, 2023
@yuliacech yuliacech marked this pull request as ready for review October 27, 2023 11:48
@yuliacech yuliacech requested a review from a team as a code owner October 27, 2023 11:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement, I dont think we do this often enough in our UIs! Changes lgtm, tested locally.

@yuliacech yuliacech enabled auto-merge (squash) October 27, 2023 12:03
@yuliacech yuliacech merged commit dba5ab7 into elastic:main Oct 27, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Osquery Cypress Tests #4 / ALL - Inventory should be able to run the previously saved query should be able to run the previously saved query
  • [job] [logs] Osquery Cypress Tests #4 / ALL - Inventory should be able to run the query should be able to run the query

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 562.1KB 562.1KB +46.0B
securitySolution 12.8MB 12.8MB +6.4KB
securitySolutionServerless 329.8KB 336.0KB +6.3KB
total +12.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.6KB 41.6KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 27, 2023
@yuliacech yuliacech deleted the im/indices_list/size_formatting branch February 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index management formatting: Right align and separate numbers in document count
5 participants