Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index management formatting: Right align and separate numbers in document count #22173

Closed
Elavina opened this issue Aug 20, 2018 · 1 comment · Fixed by #170017
Closed

Index management formatting: Right align and separate numbers in document count #22173

Elavina opened this issue Aug 20, 2018 · 1 comment · Fixed by #170017
Assignees
Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@Elavina
Copy link

Elavina commented Aug 20, 2018

Describe the feature:
Currently it's quite difficult to distinguish between large numbers on the Management/Elasticsearch/Index Management page, since they're left-aligned and have no thousands spacing. E.g.
image

The only way you can really get a quick idea of the scale of the index is from the size, not the doc count.

Simply, it would be great to have this right-aligned, and with either spaces or [regionally specific thousands separator, commas or periods]. This just makes it much easier to see differences of scale quickly.

If there's another way to make this clearer, that's also fine - it's just tedious have to pull the list of indices and stats out so I can space them so it's readable.

Describe a specific use case for the feature:
Looking through indices and wanting to compare size or detect anomalous indices.

@bmcconaghy
Copy link
Contributor

@Elavina6 this should definitely be fixed, but in the meantime you can sort on the size column and see which indices are larger.

@bmcconaghy bmcconaghy self-assigned this Aug 28, 2018
@timroes timroes added Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Nov 27, 2018
@cjcenizal cjcenizal added enhancement New value added to drive a business result and removed Feature:ILM labels Sep 30, 2019
@yuliacech yuliacech assigned yuliacech and unassigned bmcconaghy Oct 27, 2023
yuliacech added a commit that referenced this issue Oct 27, 2023
## Summary

Fixes #22173
This PR adds a formatting to the index size column of the indices list.
The number formatting is done according to the default locale in the
browser. I decided against aligning the column right because this would
looked misaligned to other columns. And aligning all of the columns
right doesn't look good either (see screenshots).

### Screenshot 
#### Formatted index size
<img width="438" alt="Screenshot 2023-10-27 at 13 32 42"
src="https://github.com/elastic/kibana/assets/6585477/87ff1b31-36b0-4951-b6aa-3cdc0c9b545e">

<details>

#### Aligning the size column right (not implemented)
<img width="413" alt="Screenshot 2023-10-27 at 13 34 18"
src="https://github.com/elastic/kibana/assets/6585477/df76a308-a927-45bd-8987-7da86a94c46f">

#### Aligning all columns right (not implemented)
<img width="1296" alt="Screenshot 2023-10-27 at 13 34 42"
src="https://github.com/elastic/kibana/assets/6585477/2604ac48-015c-49eb-9e8c-003a5c989fb1">


</details>

### Checklist


- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants