Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search source] consolidate warnings logic in kbn-search-response-warnings package #168531

Merged
merged 28 commits into from
Oct 23, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 10, 2023

prerequisite for #167906

PR consolidates all warnings logic into kbn-search-response-warnings package

@nreese nreese force-pushed the move_warnings_to_package branch from 2677556 to cd64367 Compare October 10, 2023 22:35
@nreese
Copy link
Contributor Author

nreese commented Oct 11, 2023

@elasticmachine merge upstream

@nreese nreese force-pushed the move_warnings_to_package branch from 243ee0e to 76b4a22 Compare October 11, 2023 19:49
@nreese
Copy link
Contributor Author

nreese commented Oct 12, 2023

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review October 12, 2023 15:35
@nreese nreese requested a review from a team as a code owner October 12, 2023 15:35
@nreese nreese requested a review from a team as a code owner October 12, 2023 15:35
@nreese nreese added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0 labels Oct 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks! Tested locally in Discover to confirm incomplete results warnings still display as expected 👍

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualizations changes look good. Discover owns data/search

@nreese
Copy link
Contributor Author

nreese commented Oct 22, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / Save Timeline Prompts "before each" hook for "Changed & saved timeline should NOT prompt when user navigates away out of security solution" "before each" hook for "Changed & saved timeline should NOT prompt when user navigates away out of security solution"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 469 476 +7
discover 685 687 +2
lens 1117 1134 +17
visualizations 345 362 +17
total +43

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-response-warnings 8 7 -1
data 2547 2545 -2
total -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 48.4KB 47.4KB -1.0KB
discover 584.7KB 585.4KB +657.0B
lens 1.4MB 1.4MB +1.8KB
visualizations 266.9KB 268.3KB +1.4KB
total +2.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/search-response-warnings 0 2 +2
data 24 22 -2
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 407.4KB 409.1KB +1.6KB
Unknown metric groups

API count

id before after diff
@kbn/search-response-warnings 15 14 -1
data 3202 3194 -8
total -9

async chunk count

id before after diff
discover 19 20 +1
lens 22 23 +1
visualizations 14 15 +1
total +3

ESLint disabled line counts

id before after diff
@kbn/search-response-warnings 0 1 +1
data 54 53 -1
total -0

References to deprecated APIs

id before after diff
data 32 30 -2

Total ESLint disabled count

id before after diff
@kbn/search-response-warnings 0 1 +1
data 56 55 -1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

@nreese nreese merged commit b5aa375 into elastic:main Oct 23, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants