-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[search source] consolidate warnings logic in kbn-search-response-warnings package #168531
Conversation
2677556
to
cd64367
Compare
@elasticmachine merge upstream |
243ee0e
to
76b4a22
Compare
…-ref HEAD~1..HEAD --fix'
@elasticmachine merge upstream |
…-ref HEAD~1..HEAD --fix'
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks! Tested locally in Discover to confirm incomplete results warnings still display as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visualizations changes look good. Discover owns data/search
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nreese |
prerequisite for #167906
PR consolidates all warnings logic into kbn-search-response-warnings package