Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search source] update warning messaging to include more details about clusters #167906

Closed
Tracked by #164350
nreese opened this issue Oct 3, 2023 · 1 comment · Fixed by #169578
Closed
Tracked by #164350

[search source] update warning messaging to include more details about clusters #167906

nreese opened this issue Oct 3, 2023 · 1 comment · Fixed by #169578
Assignees
@nreese
Labels
enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Oct 3, 2023 •
edited
Loading

out of scope for this issue is "Exclude clusters" action

Failure with single remote returning partial data
Screenshot 2023-10-03 at 9 47 59 AM

Failure with multiple remotes returning partial data
Screenshot 2023-10-03 at 9 48 13 AM
View when clicking "view details"
Screenshot 2023-10-03 at 9 48 19 AM
@nreese nreese added enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese self-assigned this Oct 3, 2023
@nreese nreese mentioned this issue Oct 3, 2023
Closed
10 tasks
@nreese nreese mentioned this issue Oct 10, 2023
Merged
nreese added a commit that referenced this issue Oct 23, 2023
@nreese @kibanamachine
[search source] consolidate warnings logic in kbn-search-response-war…
b5aa375 
…nings package (#168531)

prerequisite for #167906

PR consolidates all warnings logic into kbn-search-response-warnings
package

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese nreese mentioned this issue Oct 23, 2023
Merged
nreese added a commit that referenced this issue Oct 27, 2023
@nreese @kibanamachine
Update incomplete data messaging (#169578)
4b27288 
Closes #167906

PR breaks monolith component `<SearchResponseWarnings/>` into 3 separate
components: `<SearchResponseWarningsBadge/>`,
`<SearchResponseWarningsCallout/>`, and
`<SearchResponseWarningsEmptyPrompt/>`. These components are designed to
display a single messages when provided warnings from multiple requests
and display better messaging around partial results. PR also removes
`message` from `SearchResponseWarning` type.

Collaborated with @gchaps on copy.

### Test setup
1. install sample web logs data set
2. install sample flights data set
3. Create data view.
    1. Set **Index pattern** to `kibana_sample_data*`
    2. Set **Time field** to `timestamp`
4. Open discover
5. Select **kibana_sample_data*** data view
6. set time range to last 24 hours
7. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "shard failure message 123",
            "name": "kibana_sample_data_logs",
            "shard_ids": [
              0
            ]
          }
        ]
      }
    }
    ```
8) save search as **kibana_sample_data***

#### Search response warnings callout
1. Open saved search created in test setup
<img width="500" alt="Screenshot 2023-10-24 at 8 49 19 AM"
src="https://github.com/elastic/kibana/assets/373691/867cff58-c201-4a6b-b049-7136b43d053f">
2. Click "expand" icon on left of first row in documents table
3. Click "Surrounding documents"
4. Re-enable "kibana_sample_data_logs failure" filter
<img width="500" alt="Screenshot 2023-10-24 at 8 51 22 AM"
src="https://github.com/elastic/kibana/assets/373691/a50cf033-64de-4909-a47d-6ee07bb915ea">

#### Search response warnings empty prompt
1. Open saved search created in test setup
2. Add filter `DistanceKilometers is -1`
<img width="500" alt="Screenshot 2023-10-24 at 8 44 13 AM"
src="https://github.com/elastic/kibana/assets/373691/e3ae0fac-8bda-4cad-b079-8ace4e01b786">

#### Search response warnings badge
1. create new dashboard
2. add saved search created during test setup
<img width="500" alt="Screenshot 2023-10-26 at 9 15 21 AM"
src="https://github.com/elastic/kibana/assets/373691/0066e3e2-953b-4631-a7aa-f389f7e6dbfc">


#### Search response warnings toast
1. create new table aggregation visualization
2. Use saved search created during test setup as source
<img width="500" alt="Screenshot 2023-10-24 at 2 59 41 PM"
src="https://github.com/elastic/kibana/assets/373691/58aab97e-71d9-49d9-bd67-73484ec54751">

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update incomplete data messaging nreese/kibana
2 participants
@nreese @elasticmachine