Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR] Serverless - enable common config grouping #167172

Merged
merged 7 commits into from
Sep 29, 2023

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Sep 25, 2023

Summary

This PR introduces grouped common configs in serverless project FTR tests.

Details

  • With increasing number of added tests, we're running into issues with test run time (configurations are stopped at 40 minutes)
  • This PR moves the inclusion of common tests from the projects' main config.ts file to common_configs/config.group1.ts, which can easily be extended
  • As part of that, common tests in api_integration/test_suites and functional/test_suites are re-organized to no longer contain a top level index file
    • Created sub-directories and index files where needed
    • This makes it easier to group common tests when including them in project config files

Additional changes

  • Add README files to x-pack/test_serverless/[api_integration|functional]/test_suites/common
  • Rename security directory in common tests to platform_security to avoid confusion with the security project type
  • Include sample data test suite in an index file (this suite wasn't included so far and didn't run at all) and prepared it for actually working in serverless
    • it's still failing and should be fixed soon - skipped it for now

@pheyos pheyos added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 labels Sep 25, 2023
@pheyos pheyos self-assigned this Sep 25, 2023
@pheyos
Copy link
Member Author

pheyos commented Sep 25, 2023

@elasticmachine merge upstream

@pheyos pheyos marked this pull request as ready for review September 26, 2023 11:41
@pheyos pheyos requested review from a team as code owners September 26, 2023 11:41
@pheyos pheyos requested a review from dmlemeshko September 26, 2023 11:41
@pheyos
Copy link
Member Author

pheyos commented Sep 27, 2023

@elasticmachine merge upstream

@pheyos
Copy link
Member Author

pheyos commented Sep 28, 2023

@elasticmachine merge upstream

@pheyos
Copy link
Member Author

pheyos commented Sep 28, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 343c04c into elastic:main Sep 29, 2023
@pheyos pheyos deleted the svl_common_configs branch September 29, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants