-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add serverless functional tests #164798
Conversation
- Fix spelling error - Add Lens helper to set ech debug state - Remove list table dashboard search escape
x-pack/test_serverless/functional/test_suites/apps/lens/group1/config.ts
Outdated
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
x-pack/test_serverless/functional/test_suites/apps/lens/open_in_lens/tsvb/top_n.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPs changes LGTM. Please hold off on merging this until #162673 has been merged though (should be today). Then merge main
and we can test against a full serverless environment. Thanks!
x-pack/test_serverless/functional/test_suites/apps/lens/group1/index.ts
Outdated
Show resolved
Hide resolved
@nickofthyme @stratoula serverless common config grouping is merged now (#167172). With that, you can add more common config files to Don't forget to also add your config files to |
@stratoula I moved the
Looks like there are 33 issues of failed tests with similar issues here. Have you heard anything about this? The error screenshots point to an authentication problem. |
No 🤔 @pheyos or maybe @davismcphee do you have any idea which is the problem here? |
@nickofthyme @stratoula If it's failing consistently it's possible there's a missing call to |
@davismcphee @nickofthyme @stratoula there was an issue on the Elasticsearch side that caused the login/logout flakiness in serverless. A fix is merged now on their end and during first checks on the flaky test runner, the flakiness didn't come up again. So we should hopefully be good now 🤞 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary After [164798](#164798) was merged CI singnificantly slowed down because f these FTR groups: ``` x-pack/test_serverless/functional/test_suites/security/common_configs/config.group2.ts: 75.6 minutes x-pack/test_serverless/functional/test_suites/search/common_configs/config.group2.ts: 75 minutes x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group2.ts: 74.7 minutes ``` This PR splits each group into 3.
## Summary After [164798](elastic#164798) was merged CI singnificantly slowed down because f these FTR groups: ``` x-pack/test_serverless/functional/test_suites/security/common_configs/config.group2.ts: 75.6 minutes x-pack/test_serverless/functional/test_suites/search/common_configs/config.group2.ts: 75 minutes x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group2.ts: 74.7 minutes ``` This PR splits each group into 3.
Summary
This PR copies, with limited modifications, functional test suites from
test/functional
andx-pack/test/functional
Lens Smoke tests
Convert to Lens
These tests outside of serverless, assume the following vis types are accessible via the Visualize editor, however all the following types are designated readonly in serverless and thus the fn tests fail.
In place of these tests I created the identical visualizations, added them to a dashboard and exported the SOs. These dashboard and dependent visualizations are loaded in each respective test, and the assertions are run on the
Convert to Lens
option from the dashboard. All assertions are mostly unchanged or achieve the same effect.x-pack/test/functional/apps/lens/open_in_lens/agg_based
x-pack/test/functional/apps/lens/open_in_lens/tsvb
x-pack/test/functional/apps/lens/open_in_lens/dashboard/config.ts
Closes #162346