Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Hides system indices #166909

Merged
merged 9 commits into from
Sep 25, 2023
Merged

[ES|QL] Hides system indices #166909

merged 9 commits into from
Sep 25, 2023

Conversation

stratoula
Copy link
Contributor

Summary

Closes #166874

Hides indices starting with . (and considered as system from the autocomplete)

image

Followed the exact pattern that the dataview management page is using.

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 21, 2023
@stratoula stratoula marked this pull request as ready for review September 21, 2023 08:51
@stratoula stratoula requested a review from a team as a code owner September 21, 2023 08:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

ppisljar
ppisljar approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add a test for this ?

@stratoula
Copy link
Contributor Author

Thanx Peter I added one although the only thing I am doing is filtering out the indices that startWith .

@stratoula stratoula enabled auto-merge (squash) September 25, 2023 07:06
@stratoula stratoula merged commit 93ce988 into elastic:main Sep 25, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #30 / serverless observability UI Create Case creates a case
  • [job] [logs] FTR Configs #20 / serverless search UI navigation navigate search sidenav & breadcrumbs

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
textBasedLanguages 148.4KB 148.5KB +56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] We should not show hidden indices that starts with "." when using FROM
4 participants
@stratoula @elasticmachine @kibana-ci @ppisljar