Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] We should not show hidden indices that starts with "." when using FROM #166874

Closed
ninoslavmiskovic opened this issue Sep 20, 2023 · 4 comments · Fixed by #166909
Closed

[ES|QL] We should not show hidden indices that starts with "." when using FROM #166874

ninoslavmiskovic opened this issue Sep 20, 2023 · 4 comments · Fixed by #166909
Assignees
@stratoula
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ninoslavmiskovic
Copy link
Contributor

Describe the feature:

When in ES|QL mode, we should not show hidden indices that start with "." .

These are system indices and are not meant to be user-facing.

Skærmbillede 2023-09-20 kl 20 44 38
@ninoslavmiskovic ninoslavmiskovic added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:ES|QL ES|QL related features in Kibana labels Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula
Copy link
Contributor

stratoula commented Sep 21, 2023 •
edited
Loading

@ninoslavmiskovic we are hiding indices marked as hidden (such as .kibana). These are not flagged as such so we show them. Possibly we can do whatever the dataview page is doing

@stratoula stratoula reopened this Sep 21, 2023
@stratoula stratoula added enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Sep 21, 2023
@ninoslavmiskovic
Copy link
Contributor Author

@ninoslavmiskovic we are hiding indices marked as hidden (such as .kibana). These are not flagged as such so we show them. Possibly we can do whatever the dataview page is doing

I just checked in the index management under "hidden indices" and they appear there.

The indices around the O11y AI assistant are a bug (and will be hidden), but the .alert ones in this example are (at least from the UI)

If it makes sense - ++ on doing the same method as data-view. Right now when creating a new data-view the hidden indices are not showing up.

Skaermoptagelse.2023-09-21.kl.09.52.27.mov

@stratoula stratoula mentioned this issue Sep 21, 2023
Merged
@stratoula stratoula self-assigned this Sep 21, 2023
@stratoula
Copy link
Contributor

Yeah dont worry I will hide all the indices starting with dot (this is what the dataview management page is doing)

stratoula added a commit that referenced this issue Sep 25, 2023
@stratoula
[ES|QL] Hides system indices (#166909)
93ce988 
## Summary

Closes #166874

Hides indices starting with . (and considered as system from the
autocomplete)

<img width="785" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/9c4cce79-c844-41b6-a30e-06dad49f7c52">


Followed the exact pattern that the dataview management page is using.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Hides system indices stratoula/kibana
3 participants
@elasticmachine @stratoula @ninoslavmiskovic