[Security Solution] Preparing Cypress to be able to execute on a real serverless environment #166905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-real-environment # Conflicts: # x-pack/test/security_solution_cypress/cypress/tasks/login.ts # x-pack/test/security_solution_cypress/package.json
MadameSheema
force-pushed
the
cypress/security-real-environment
branch
from
56c0e53 to
5a612d9
Compare
MadameSheema
changed the title
|
|
MadameSheema
added
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
dkirchan
approved these changes
Sep 21, 2023
x-pack/test/security_solution_cypress/cypress/cypress_serverless.config.ts
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/cypress_serverless.config.ts
Show resolved
Hide resolved
semd
reviewed
Sep 21, 2023
x-pack/test/security_solution_cypress/cypress/support/es_archiver.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Sep 21, 2023
x-pack/test/security_solution_cypress/cypress/support/es_archiver.ts
Outdated
Show resolved
Hide resolved
…ver.ts Co-authored-by: Sergi Massaneda <[email protected]>
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
maximpn
approved these changes
Sep 22, 2023
| @@ -27,6 +27,7 @@ export default defineCypressConfig({ | |||
| e2e: { | |||
| experimentalRunAllSpecs: true, | |||
| experimentalMemoryManagement: true, | |||
| experimentalCspAllowList: ['default-src', 'script-src', 'script-src-elem'], | |||
There was a problem hiding this comment.
I'm a bit of out context here and just curious why we permit CSP directives now? It looks like an orthogonal change in this PR.
There was a problem hiding this comment.
Hey @maximpn!! In order to be able to execute Cypress we were setting the csp parameters when creating the instances for testing in x-pack/test/security_solution_cypress/config.ts. In a real (deployed) serverless environment, we don't have a way of doing it, so the above line helps us to execute the tests without facing any issues.
joemcelroy
pushed a commit
to joemcelroy/kibana
that referenced
this pull request
Sep 25, 2023
… serverless environment (elastic#166905) Co-authored-by: YulNaumenko <[email protected]> Co-authored-by: Sergi Massaneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done to be prepared for these changes
Summary
This PR provides the changes needed to be able to execute cypress tests in a real serverless environment.
How to test it
Create a deployed project (you can use QAF for the creation and management of it. It is a pretty convenient tool since it easily provides you the password and the username)
Execute cypress in your machine from
x-pack/test/security_solution_cypress:Known limitations
completecan be executedTo follow up
essentialsandcompleteBlockers
We need to have cypress at least in 12.15.0 version to be able to execute them on a real serverless since from that version test pages with targetedContent-Security-PolicyandContent-Security-Policy-Report-Onlyheader directives can be tested by specifying the allow list via the experimentalCspAllowList configuration option.#165869Blocker solved :)