Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Loading auditbeat data in a global hook #165953

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Sep 7, 2023

Summary

Originally we were adding the auditbeat data when configuring the FTR environment that we use for testing purposes. That was originally like that because back then cypress didn't provide a way to add a global hook.

Now that we can, we have moved the loading of the generic data to that hook, since that is going to be beneficial when running the tests on a real serverless environment, since instead of an outside script is the same cypress the one ingesting the initial set of data.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Cypress Tests #1 / Cases Creates a new case with timeline and opens the timeline Creates a new case with timeline and opens the timeline
  • [job] [logs] Serverless Security Cypress Tests #1 / Prebuilt rules Alerts rules, prebuilt rules "before each" hook for "Loads prebuilt rules" "before each" hook for "Loads prebuilt rules"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema changed the title loading auditbeat data in a global hook [Security Solution] Loading auditbeat data in a global hook Sep 7, 2023
@MadameSheema MadameSheema self-assigned this Sep 7, 2023
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 labels Sep 7, 2023
@MadameSheema MadameSheema marked this pull request as ready for review September 7, 2023 18:22
@MadameSheema MadameSheema requested review from a team as code owners September 7, 2023 18:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) September 7, 2023 18:23
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It will also help to reproduce the test on a remote ES.

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vgomez-el
Copy link

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants