-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Loading auditbeat data in a global hook #165953
[Security Solution] Loading auditbeat data in a global hook #165953
Conversation
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! It will also help to reproduce the test on a remote ES.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
LGTM! |
Summary
Originally we were adding the auditbeat data when configuring the FTR environment that we use for testing purposes. That was originally like that because back then cypress didn't provide a way to add a global hook.
Now that we can, we have moved the loading of the generic data to that hook, since that is going to be beneficial when running the tests on a real serverless environment, since instead of an outside script is the same cypress the one ingesting the initial set of data.