Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D/2023 06 14 global drift #166710

Closed
wants to merge 32 commits into from
Closed

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 19, 2023

Summary

close #159691

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

Dosant and others added 17 commits June 14, 2023 10:30
…obal-drift

# Conflicts:
#	packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
#	src/core/public/styles/chrome/_banner.scss
#	x-pack/plugins/enterprise_search/public/applications/enterprise_search_overview/components/product_selector/product_selector.tsx
#	x-pack/plugins/observability/public/pages/overview/overview.tsx
@github-actions
Copy link
Contributor

Documentation preview:

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 22, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Alerts alerts getActionErrorLog no_kibana_privileges at space1 gets action error logs for rules with action errors with appropriate authorization
  • [job] [logs] FTR Configs #68 / alerting api integration security and spaces enabled - Group 2 Alerts alerts getActionErrorLog no_kibana_privileges at space1 gets action error logs for rules with action errors with appropriate authorization
  • [job] [logs] FTR Configs #68 / alerting api integration security and spaces enabled - Group 2 Alerts alerts getActionErrorLog no_kibana_privileges at space1 gets action error logs for rules with action errors with appropriate authorization
  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Alerts alerts getActionErrorLog no_kibana_privileges at space1 gets action error logs for rules with action errors with appropriate authorization
  • [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name
  • [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudChat 14 22 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cloudChat 2 0 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudChat 2.9KB 3.2KB +355.0B
dataVisualizer 605.9KB 605.8KB -40.0B
enterpriseSearch 2.6MB 2.6MB -43.0B
fleet 1.2MB 1.2MB -45.0B
home 164.2KB 164.2KB -64.0B
observability 1.0MB 1.0MB -43.0B
securitySolution 12.8MB 12.8MB -58.0B
total +62.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudChat 5.3KB 11.6KB +6.3KB
dataVisualizer 23.0KB 22.9KB -139.0B
enterpriseSearch 39.9KB 39.8KB -139.0B
fleet 143.1KB 143.0KB -139.0B
home 11.5KB 11.5KB -32.0B
observability 100.2KB 100.0KB -139.0B
securitySolution 62.5KB 62.3KB -139.0B
total +5.5KB
Unknown metric groups

API count

id before after diff
cloudChat 3 0 -3

References to deprecated APIs

id before after diff
cloudChat 1 4 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drift] Global Drift
3 participants