Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Reorganize lens related types #166285

Merged
merged 6 commits into from
Sep 20, 2023
Merged

[Infra UI] Reorganize lens related types #166285

merged 6 commits into from
Sep 20, 2023

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Sep 12, 2023 •
edited
Loading

part of: #165825

Summary

While working on #166276 I noticed that some lens types could be reorganized. This PR is for that.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos linked an issue Sep 12, 2023 that may be closed by this pull request
[Infra UI] KPI Tiles - Update to 'Average of X' #165825
Closed
@crespocarlos crespocarlos added chore Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ObsHosts Hosts feature within Observability labels Sep 13, 2023
@crespocarlos crespocarlos changed the title Refactor lens chart types [Infra UI] Reorganize lens related types Sep 13, 2023
@crespocarlos crespocarlos marked this pull request as ready for review September 18, 2023 13:45
@crespocarlos crespocarlos requested a review from a team as a code owner September 18, 2023 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos crespocarlos self-assigned this Sep 20, 2023
@jennypavlova jennypavlova self-requested a review September 20, 2023 12:59
jennypavlova
jennypavlova approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Thanks for organizing the types!

...ins/infra/public/common/visualizations/lens/dashboards/asset_details/host/host_kpi_charts.ts Outdated
layers: MetricChartLayerParams;
toolTip: string;
}
import { KPIChartProps } from '../../types';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { KPIChartProps } from '../../types';
import type { KPIChartProps } from '../../types';

@crespocarlos crespocarlos force-pushed the 165825-refactor branch 2 times, most recently from ac594a0 to b093481 Compare September 20, 2023 14:12
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / serverless security UI Cases List empty state displays an empty list with an add button correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @crespocarlos

@crespocarlos crespocarlos merged commit d0b759a into elastic:main Sep 20, 2023
@crespocarlos crespocarlos deleted the 165825-refactor branch September 20, 2023 15:12
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Sep 21, 2023
@crespocarlos @kibanamachine @gergoabraham
[Infra UI] Reorganize lens related types (elastic#166285)
6902a1b 
part of: elastic#165825

## Summary

While working on elastic#166276 I noticed
that some lens types could be reorganized. This PR is for that.

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees

@crespocarlos crespocarlos

Labels
backport:skip This commit does not require backporting chore Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] KPI Tiles - Update to 'Average of X'
6 participants
@crespocarlos @apmmachine @elasticmachine @kibana-ci @jennypavlova @kibanamachine