-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] KPI Tiles - Update to 'Average of X' #165825
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Metrics UI
Metrics UI feature
Feature:ObsHosts
Hosts feature within Observability
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Comments
roshan-elastic
added
Feature:Metrics UI
Metrics UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Feature:ObsHosts
Hosts feature within Observability
labels
Sep 6, 2023
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
roshan-elastic
added
the
needs-refinement
A reason and acceptance criteria need to be defined for this issue
label
Sep 6, 2023
hi @roshan-elastic, i would like to work on this issue. |
This is a bug. The KPIs are already prepared to display the host limit @vrun1208 , I hadn't seen your comment and already prepared a fix, but you're more than welcome to submit your PR |
crespocarlos
added
the
bug
Fixes for quality problems that affect the customer experience
label
Sep 12, 2023
crespocarlos
removed
the
needs-refinement
A reason and acceptance criteria need to be defined for this issue
label
Sep 12, 2023
This was referenced Sep 12, 2023
crespocarlos
added a commit
that referenced
this issue
Sep 14, 2023
#166276) closes #165825 ## Summary This ticket fixes the problem with the KPI subtitles that were not correctly showing the host limit information https://github.com/elastic/kibana/assets/2767137/c2bb6109-82f6-4e2a-8a00-4ddd3f33fba5 Replacing the `useLazyRef` with `useMemo` in the `use_lens_attributes` to fix this problem, caused many problems with charts re-rendering, now that the attribute builder is no longer a singleton. Charts are heavy components and rendering them unnecessarily degrades performance considerably. So, besides fixing the main issue, I had to fix in this PR the other problems that surfaced after the change. I also renamed a few things. ### How to test this PR - Start a local Kibana instance - Run slingshot with ~200 hosts for a couple of days - Navigate to `Infrastructure` > `Hosts` and change the host limit to confirm that the KPI subtitle will reflect the selection - Check if the clicks on the tabs and checkboxes are responding quickly. --------- Co-authored-by: Kibana Machine <[email protected]>
crespocarlos
added a commit
that referenced
this issue
Sep 20, 2023
part of: #165825 ## Summary While working on #166276 I noticed that some lens types could be reorganized. This PR is for that. --------- Co-authored-by: Kibana Machine <[email protected]>
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this issue
Sep 21, 2023
part of: elastic#165825 ## Summary While working on elastic#166276 I noticed that some lens types could be reorganized. This PR is for that. --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Metrics UI
Metrics UI feature
Feature:ObsHosts
Hosts feature within Observability
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
📖 Description
It might not be clear to users that the 'averages' are only showing for the hosts returned within the host limit:
i.e. the CPU Usage Average is showing for only the 50 hosts returned (not the full 90 in the example below)
💡 Solution Proposal
When the host limit restricts the hosts returned, could we update the 'Average' for each of the KPI tiles (except for the first Hosts tile) to say:
"Average (for X hosts)"
The text was updated successfully, but these errors were encountered: