Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Use latest published version for initial agent download #166150

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

joshdover
Copy link
Contributor

Summary

Closes #139174

Builds on top of #165978 to use the latest actually published version of Agent to populate all of the install scripts and k8s manifests for installing agent. This is only enabled when xpack.fleet.internal.onlyAllowAgentUpgradeToKnownVersions: true is set on Serverless.

This way users setting up Agent on Serverless projects will not be shown SNAPSHOT builds or pre-releases.

You can test this by placing a JSON file at x-pack/plugins/fleet/target/agent_versions_list.json like:

[
  "8.8.0",
  "8.7.0"
]

Fleet will always show the first version in the list for new installations.

Checklist

Delete any items that are not applicable to this PR.

@joshdover joshdover added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team Serverless labels Sep 11, 2023
@joshdover joshdover requested a review from a team as a code owner September 11, 2023 11:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23 jlind23 requested a review from hop-dev September 11, 2023 11:04
@jlind23 jlind23 added the release_note:skip Skip the PR/issue when compiling release notes label Sep 11, 2023
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshdover joshdover enabled auto-merge (squash) September 11, 2023 16:25
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 11, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 943 944 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +236.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 142.5KB 142.8KB +316.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 32d743a into elastic:main Sep 11, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 11, 2023
yngrdyn added a commit that referenced this pull request Sep 21, 2023
…166811)

Relates to #165657.

In #166150 a method that returns
the latest available version was introduced in fleet.

We would like to use this method as a consumers of fleet plugin
([observability_onboarding](https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability_onboarding)).
Additionally we would like to decide from outside fleet wether we want
to include currentVersion or not, this is specially useful for us since
we download the elastic agent executable from
https://artifacts.elastic.co/downloads/beats/elastic-agent/ where
snapshots are not available.
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Sep 21, 2023
…lastic#166811)

Relates to elastic#165657.

In elastic#166150 a method that returns
the latest available version was introduced in fleet.

We would like to use this method as a consumers of fleet plugin
([observability_onboarding](https://github.com/elastic/kibana/tree/main/x-pack/plugins/observability_onboarding)).
Additionally we would like to decide from outside fleet wether we want
to include currentVersion or not, this is specially useful for us since
we download the elastic agent executable from
https://artifacts.elastic.co/downloads/beats/elastic-agent/ where
snapshots are not available.
@watson watson added the Project:Serverless Work as part of the Serverless project for its initial release label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: Latest snapshot version not available under Agent upgrade modal for Snapshot builds.
8 participants