-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet]: Latest snapshot version not available under Agent upgrade modal for Snapshot builds. #139174
Comments
Pinging @elastic/fleet (Team:Fleet) |
@manishgupta-qasource Please review. |
Secondary review for this ticket is Done |
Hi @joshdover Build Details: Screenshots: We have tested agent upgrades from 8.4.0>8.4.1 BC1 using Agent Binary feature and found it working fine. However, we are blocked to test agent upgrade (lower than 8.4.0) on 8.4.1 Snapshot because of this issue. |
@amolnater-qasource @simranvaseer-qasource is this still an issue? |
We have revalidated this issue on latest 8.6 SNAPSHOT and observed it still reproducible. Observations:
Build details: Screen Recording: Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-11-24.12-35-44.mp4Please let us know if anything else is required from our end. |
Hi Team, We have revalidated this issue on latest 8.7.0 SNAPSHOT and found this issue still reproducible.
Build details: Please let us know if anything else is required from our end. |
Do we need to support this? It should be possible to type in the number manually + ENTER for testing purposes. |
From a customer perspective we don't need to support this imo. Customers (users of that modal) will only need GA releases. @joshdover does this have development value? say you have provided a fix and the upgrade path for that fix needs to be tested (just a thought) |
Assuming that this works as I think it should, I don't think we have development value in this if we can just type in the version manually. |
Thank you for looking into this. Build details: Screen Recording: Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-02-16.01-16-11.mp4Please let us know if anything else is required from our end. |
Hi Team, We have revalidated this issue on latest 8.10.0 SNAPSHOT kibana cloud environment and found it still reproducible. Observations:
Build details: Please let us know if anything else is required from our end. Thanks! |
Yes this is still a bug, but was dependent on some Agent changes which are now complete. We can now modify Fleet to send the |
This seems important for upgrade testing so I'm moving this forward a bit - it should also be a small change. |
Sorry I'm not clear what we are intending to implement here @joshdover @jlind23, should this be the behaviour:
Or if the current kibana version is a snapshot (or we are in dev mode), we could just add the current kibana version + "-SNAPSHOT" to the list? |
If the Kibana version is a snapshot, we should be able to show the snapshot versions available. |
@hop-dev Per our Slack conversation in serverless environment we should only rely on versions coming from the webversions API that are pulled during the build. |
I added the points above in the issue description to make sure these are fixed/worked on. |
Added one more point to the description to remove the logic we have (I think) for stripping the |
@jlind23 I think we should fast-track the Serverless fix as it is going to confuse a lot of folks during the testing period next week. Should we split it out as a separate P1 issue? |
@joshdover This is Mark's next priority so I believe this would be fixed and available in Serverless fairly soon. |
Serveless parts aren't quite done for initial download. PR incoming |
Hi Team, We have revalidated this issue on latest 8.11.0 SNAPSHOT kibana cloud environment and had below observations: Observations:
Build details: Screen Recording: Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-09-19.12-34-00.mp4Hence we are marking this issue as QA:Validated. Thanks! |
Kibana version: 8.4 Snapshot Kibana cloud environment
Host OS and Browser version: All, All
Build details:
Preconditions:
Steps to reproduce:
Expected Result:
Latest snapshot version should be available under Agent upgrade modal for Snapshot builds.
Screenshots:
Issue outcome:
-SNAPSHOT
suffix from the version before sending the action to the agent. It should send the full version with-SNAPSHOT
.The text was updated successfully, but these errors were encountered: