Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: Latest snapshot version not available under Agent upgrade modal for Snapshot builds. #139174

Closed
3 tasks
amolnater-qasource opened this issue Aug 22, 2022 · 23 comments · Fixed by #165978 or #166150
Closed
3 tasks
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

amolnater-qasource commented Aug 22, 2022

Kibana version: 8.4 Snapshot Kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.4.0 Snapshot
BUILD: 55395
COMMIT: 1922ab0b6f8dc2906ef10f3fb65fc4d0e0076f90

Preconditions:

  1. 8.4 Snapshot Kibana cloud environment should be available.
  2. Lower version agents should be installed.

Steps to reproduce:

  1. Navigate to Fleet>Agents tab.
  2. Click on Upgrade agent and observe 8.4 Snapshot version not available.
    • Because of this agent upgrades fail on 8.4 Snapshot.

Expected Result:
Latest snapshot version should be available under Agent upgrade modal for Snapshot builds.

Screenshots:
4
3

Issue outcome:

  • In serverless environment we only rely on versions coming from the webversions API that are pulled during the build.
  • If the Kibana version is a snapshot, we should be able to show the snapshot versions available
  • If a user selects a snapshot version OR manually types it in, Fleet should not strip the -SNAPSHOT suffix from the version before sending the action to the agent. It should send the full version with -SNAPSHOT.
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@ghost
Copy link

ghost commented Aug 26, 2022

Hi @joshdover
We have revalidated this issue on latest 8.4.1 Snapshot Kibana Cloud environment and found it still reproducible.

Build Details:
8.4.1 Snapshot
BUILD: 55429
COMMIT: 6f7ac5a

Screenshots:
Agent Upgrade on 8.4.1 Snapshot:
Screenshot (20)

We have tested agent upgrades from 8.4.0>8.4.1 BC1 using Agent Binary feature and found it working fine.

However, we are blocked to test agent upgrade (lower than 8.4.0) on 8.4.1 Snapshot because of this issue.
Thanks

@nimarezainia
Copy link
Contributor

@amolnater-qasource @simranvaseer-qasource is this still an issue?

@amolnater-qasource
Copy link
Author

Hi @nimarezainia

We have revalidated this issue on latest 8.6 SNAPSHOT and observed it still reproducible.

Observations:

  • Latest snapshot version not available under Agent upgrade modal for Snapshot builds.

Build details:
BUILD: 58520
COMMIT: 7b6d34c

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-11-24.12-35-44.mp4

Please let us know if anything else is required from our end.
Thanks

@amolnater-qasource
Copy link
Author

Hi Team,

We have revalidated this issue on latest 8.7.0 SNAPSHOT and found this issue still reproducible.

  • Latest snapshot version not available under Agent upgrade modal for Snapshot builds.

Build details:
BUILD: 60431
COMMIT: 99f69f7

Screenshots:
19
18

Please let us know if anything else is required from our end.
Thanks

@joshdover
Copy link
Contributor

Do we need to support this? It should be possible to type in the number manually + ENTER for testing purposes.

@nimarezainia
Copy link
Contributor

From a customer perspective we don't need to support this imo. Customers (users of that modal) will only need GA releases.

@joshdover does this have development value? say you have provided a fix and the upgrade path for that fix needs to be tested (just a thought)

@joshdover
Copy link
Contributor

It should be possible to type in the number manually + ENTER for testing purposes.

Assuming that this works as I think it should, I don't think we have development value in this if we can just type in the version manually.

@amolnater-qasource
Copy link
Author

Hi @joshdover @nimarezainia

Thank you for looking into this.
We have attempted to manually write the version 8.7.0-SNAPSHOT under the agent upgrade modal, however it itself edits it to 8.7.0.

Build details:
8.7.0-SNAPSHOT
BUILD: 60431
COMMIT: 99f69f7

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-02-16.01-16-11.mp4

Please let us know if anything else is required from our end.
Thanks

@amolnater-qasource
Copy link
Author

Hi Team,

We have revalidated this issue on latest 8.10.0 SNAPSHOT kibana cloud environment and found it still reproducible.

Observations:

  • Latest snapshot version not available under Agent upgrade modal for Snapshot builds.

Screenshot:
image

Build details:
VERSION: 8.10.0 SNAPSHOT
BUILD: 65448
COMMIT: 97176a5

Please let us know if anything else is required from our end.

Thanks!

@joshdover
Copy link
Contributor

Yes this is still a bug, but was dependent on some Agent changes which are now complete. We can now modify Fleet to send the -SNAPSHOT in the version number down to the Agent. It will only work for upgrading Agents from 8.9.0 -> 8.10.0-SNAPSHOT or later.

@joshdover
Copy link
Contributor

This seems important for upgrade testing so I'm moving this forward a bit - it should also be a small change.

@hop-dev
Copy link
Contributor

hop-dev commented Aug 24, 2023

Sorry I'm not clear what we are intending to implement here @joshdover @jlind23, should this be the behaviour:

It should be possible to type in the number manually + ENTER for testing purposes.

Or if the current kibana version is a snapshot (or we are in dev mode), we could just add the current kibana version + "-SNAPSHOT" to the list?

@jlind23
Copy link
Contributor

jlind23 commented Aug 24, 2023

If the Kibana version is a snapshot, we should be able to show the snapshot versions available.

@jlind23
Copy link
Contributor

jlind23 commented Aug 29, 2023

@hop-dev Per our Slack conversation in serverless environment we should only rely on versions coming from the webversions API that are pulled during the build.

@jlind23
Copy link
Contributor

jlind23 commented Aug 29, 2023

I added the points above in the issue description to make sure these are fixed/worked on.

@joshdover
Copy link
Contributor

Added one more point to the description to remove the logic we have (I think) for stripping the -SNAPSHOT suffix.

@joshdover
Copy link
Contributor

@jlind23 I think we should fast-track the Serverless fix as it is going to confuse a lot of folks during the testing period next week. Should we split it out as a separate P1 issue?

@jlind23
Copy link
Contributor

jlind23 commented Sep 1, 2023

@joshdover This is Mark's next priority so I believe this would be fixed and available in Serverless fairly soon.
How did you wanted to fast-track this otherwise?

@joshdover
Copy link
Contributor

Serveless parts aren't quite done for initial download. PR incoming

@amolnater-qasource
Copy link
Author

Hi Team,

We have revalidated this issue on latest 8.11.0 SNAPSHOT kibana cloud environment and had below observations:

Observations:

Build details:
VERSION: 8.11.0 SNAPSHOT
BUILD: 67091
COMMIT: e00aa75

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-09-19.12-34-00.mp4

Hence we are marking this issue as QA:Validated.

Thanks!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
7 participants