-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Update breadcrumbs #165894
[Index Management] Update breadcrumbs #165894
Conversation
75c1ae3
to
25b877f
Compare
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @yuliacech! It looks like the breadcrumb to clone a component template isn't correct, although the heading also says "Create..." 🤔 Would you mind taking a look? Otherwise, everything LGTM.
Thanks a lot for the review, @alisonelizabeth! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Did not test the latest locally, but code changes and screenshot LGTM.
Hey @gchaps, could you please have a look at this PR? We are fixing the breadcrumbs in Index Management and it would be great to have them reviewed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
I suggest to merge this PR for now and review the copy in the PR to enable the details page by default. |
Summary
Fixes #165844
Partially addresses #122577
This PR fixes the inconsistency with breadcrumbs in Index Management. Previously, the breadcrumbs were updated only when an index template or a component template was being created/edited. This PR adds breadcrumbs for each of 4 main tabs: indices, data streams, index templates, component templates. It also adds breadcrumbs for the new index details page.
Note for reviewers: Tabs "Documents" and "Pipelines" on the new index details page will not be implemented for now, so there are no breadcrumbs for them.
Note for copy review: This PR can be reviewed only in terms on breadcrumbs in Index Management. The copy review for the new index details page can be done in this PR.
Screenshots
Indices list
Breadcrumbs "Indices"
Index details - overview tab
Breadcrumbs "Indices" (link) => "Index details" -> "Overview"
Index details - mappings tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Mappings"
Index details - settings tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Settings"
Index details - stats tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Stats"
Data streams
Breadcrumbs "Data streams"
Index templates
Breadcrumbs "Templates"
Component templates
Breadcrumbs "Component templates"
Checklist