Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Management] Update breadcrumbs on the main page #165844

Closed
yuliacech opened this issue Sep 6, 2023 · 1 comment · Fixed by #165894
Closed

[Index Management] Update breadcrumbs on the main page #165844

yuliacech opened this issue Sep 6, 2023 · 1 comment · Fixed by #165894
Assignees
@yuliacech
Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

yuliacech commented Sep 6, 2023 •
edited
Loading

The Index Management plugin doesn't update the breadcrumbs when the selected tab is changed. The breadcrumb should be one of "Indices", "Data streams", "Index templates" or "Component templates" depending on which tab is currently selected.
After #165705 is merged, the breadcrumb should also be updated to reflect that the index details page is opened: "Indices" -> "Index details" -> "Overview" | "Mappings" | "Settings" | "Stats".

Note: The breadcrumb is already set correctly on the new index/component template page.

Related to #122577
@yuliacech yuliacech added enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Sep 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech self-assigned this Sep 6, 2023
@yuliacech yuliacech mentioned this issue Sep 6, 2023
Merged
2 tasks
yuliacech added a commit that referenced this issue Sep 21, 2023
@yuliacech @kibanamachine
[Index Management] Update breadcrumbs (#165894)
969bbb0 
## Summary
Fixes #165844
Partially addresses #122577 

This PR fixes the inconsistency with breadcrumbs in Index Management.
Previously, the breadcrumbs were updated only when an index template or
a component template was being created/edited. This PR adds breadcrumbs
for each of 4 main tabs: indices, data streams, index templates,
component templates. It also adds breadcrumbs for the new index details
page.

**Note for reviewers:** Tabs "Documents" and "Pipelines" on the new
index details page will not be implemented for now, so there are no
breadcrumbs for them.

**Note for copy review**: This PR can be reviewed only in terms on
breadcrumbs in Index Management. The copy review for the new index
details page can be done in this
[PR](#165705).

### Screenshots 

#### Indices list
Breadcrumbs "Indices"

<img width="1318" alt="Screenshot 2023-09-07 at 17 22 56"
src="https://github.com/elastic/kibana/assets/6585477/1a670df6-b0b2-4272-b7ec-e50719884ad8">

#### Index details - overview tab
Breadcrumbs "Indices" (link) => "Index details" -> "Overview"
<img width="1130" alt="Screenshot 2023-09-08 at 17 20 45"
src="https://github.com/elastic/kibana/assets/6585477/87b75a2c-d3e2-454d-8ad5-979feb3dc8a5">


#### Index details - mappings tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Mappings"
<img width="1319" alt="Screenshot 2023-09-07 at 17 23 53"
src="https://github.com/elastic/kibana/assets/6585477/d42baf78-9133-4c87-bdbd-1aedad119e62">

#### Index details - settings tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Settings"
<img width="1305" alt="Screenshot 2023-09-07 at 17 24 00"
src="https://github.com/elastic/kibana/assets/6585477/bf94497c-4ca3-413c-be57-37499c0839ba">

#### Index details - stats tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Stats"
<img width="1300" alt="Screenshot 2023-09-07 at 17 24 12"
src="https://github.com/elastic/kibana/assets/6585477/c1798ac2-7169-4bfe-8732-ed3f8e6d812e">

#### Data streams
Breadcrumbs "Data streams"
<img width="1319" alt="Screenshot 2023-09-07 at 17 23 03"
src="https://github.com/elastic/kibana/assets/6585477/f4d0230e-994f-4537-a43d-065d364ffc7c">

#### Index templates
Breadcrumbs "Templates" 
<img width="1319" alt="Screenshot 2023-09-07 at 17 23 10"
src="https://github.com/elastic/kibana/assets/6585477/610c609c-1213-4388-9c73-68711c2c4bb6">

#### Component templates
Breadcrumbs "Component templates" 
<img width="1303" alt="Screenshot 2023-09-07 at 17 23 28"
src="https://github.com/elastic/kibana/assets/6585477/4f90eadb-a409-4e53-84f0-92b5f40b7639">



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuliacech yuliacech

Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Index Management] Update breadcrumbs yuliacech/kibana
2 participants
@yuliacech @elasticmachine