Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Normalise network and Disk rates for Hosts across time ranges #165680

Merged
merged 5 commits into from
Sep 6, 2023
Merged

[Infra UI] Normalise network and Disk rates for Hosts across time ranges #165680

merged 5 commits into from
Sep 6, 2023

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Sep 5, 2023 •
edited by kibanamachine
Loading

Closes #164152

Summary

This PR normalizes the disk and network charts per second. The charts changed:
Disk IOPS (read/write)
diskiops
Network (rx/tx)
network
Disk Throughput (read/write)
diskth

Testing

  1. Go to hosts view and check network and disk charts (they should be normalized per second)
  2. Open the host flyout and check network and disk charts (they should be normalized per second)
normalized_per_second.mov

@jennypavlova jennypavlova self-assigned this Sep 5, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 5, 2023
@jennypavlova jennypavlova marked this pull request as ready for review September 5, 2023 12:43
@jennypavlova jennypavlova requested a review from a team as a code owner September 5, 2023 12:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

mykolaharmash
mykolaharmash approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything works as expected 🚀

@jennypavlova jennypavlova enabled auto-merge (squash) September 6, 2023 10:29
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #8 / Add endpoint exception from rule details "before all" hook for "creates an exception item" "before all" hook for "creates an exception item"
  • [job] [logs] Serverless Security Explore Cypress Tests #2 / Cases connectors "before each" hook for "Configures a new connector" "before each" hook for "Configures a new connector"
  • [job] [logs] FTR Configs #68 / dashboard feature controls dashboard feature controls security "after all" hook in "dashboard feature controls security"
  • [job] [logs] FTR Configs #68 / dashboard feature controls dashboard feature controls security global dashboard read-only privileges can view existing Dashboard
  • [job] [logs] Serverless Security Investigations Cypress Tests #2 / Row renderers "before each" hook for "Row renderers should be enabled by default" "before each" hook for "Row renderers should be enabled by default"
  • [job] [logs] Serverless Observability Examples Tests / serverless examples UI Unified Field List Examples Field stats field distribution "before all" hook for "should return an auto histogram for numbers and top values"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +84.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@jennypavlova jennypavlova merged commit 1487672 into elastic:main Sep 6, 2023
@jennypavlova jennypavlova deleted the 164152-infra-ui-normalise-network-and-disk-rates-for-hosts-across-time-ranges branch September 6, 2023 11:32
@kibanamachine kibanamachine mentioned this pull request Sep 6, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2023
@jennypavlova
[Infra UI] Normalise network and Disk rates for Hosts across time ran…
53f0e68 
…ges (elastic#165680)

Closes elastic#164152

## Summary

This PR normalizes the disk and network charts per second. The charts
changed:
Disk IOPS (read/write)
<img width="390" alt="diskiops"
src="https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e">
Network (rx/tx)
<img width="402" alt="network"
src="https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a">
Disk Throughput (read/write)
<img width="590" alt="diskth"
src="https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed">

## Testing

1. Go to hosts view and check network and disk charts (they should be
normalized per second)
2. Open the host flyout and check network and disk charts (they should
be normalized per second)

https://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365
(cherry picked from commit 1487672)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 6, 2023
@kibanamachine @jennypavlova
[8.10] [Infra UI] Normalise network and Disk rates for Hosts across t…
db95f6c 
…ime ranges (#165680) (#165836)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Infra UI] Normalise network and Disk rates for Hosts across time
ranges (#165680)](#165680)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-06T11:30:51Z","message":"[Infra
UI] Normalise network and Disk rates for Hosts across time ranges
(#165680)\n\nCloses #164152 \r\n\r\n## Summary\r\n\r\nThis PR normalizes
the disk and network charts per second. The charts\r\nchanged:\r\nDisk
IOPS (read/write) \r\n<img width=\"390\"
alt=\"diskiops\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e\">\r\nNetwork
(rx/tx)\r\n<img width=\"402\"
alt=\"network\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a\">\r\nDisk
Throughput (read/write)\r\n<img width=\"590\"
alt=\"diskth\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed\">\r\n\r\n##
Testing\r\n\r\n1. Go to hosts view and check network and disk charts
(they should be\r\nnormalized per second)\r\n2. Open the host flyout and
check network and disk charts (they should\r\nbe normalized per
second)\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365","sha":"14876726f4f6edd57672644a322e55cd3d2afd6a","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring
UI","release_note:skip","backport:prev-minor","v8.11.0"],"number":165680,"url":"https://github.com/elastic/kibana/pull/165680","mergeCommit":{"message":"[Infra
UI] Normalise network and Disk rates for Hosts across time ranges
(#165680)\n\nCloses #164152 \r\n\r\n## Summary\r\n\r\nThis PR normalizes
the disk and network charts per second. The charts\r\nchanged:\r\nDisk
IOPS (read/write) \r\n<img width=\"390\"
alt=\"diskiops\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e\">\r\nNetwork
(rx/tx)\r\n<img width=\"402\"
alt=\"network\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a\">\r\nDisk
Throughput (read/write)\r\n<img width=\"590\"
alt=\"diskth\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed\">\r\n\r\n##
Testing\r\n\r\n1. Go to hosts view and check network and disk charts
(they should be\r\nnormalized per second)\r\n2. Open the host flyout and
check network and disk charts (they should\r\nbe normalized per
second)\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365","sha":"14876726f4f6edd57672644a322e55cd3d2afd6a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165680","number":165680,"mergeCommit":{"message":"[Infra
UI] Normalise network and Disk rates for Hosts across time ranges
(#165680)\n\nCloses #164152 \r\n\r\n## Summary\r\n\r\nThis PR normalizes
the disk and network charts per second. The charts\r\nchanged:\r\nDisk
IOPS (read/write) \r\n<img width=\"390\"
alt=\"diskiops\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e\">\r\nNetwork
(rx/tx)\r\n<img width=\"402\"
alt=\"network\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a\">\r\nDisk
Throughput (read/write)\r\n<img width=\"590\"
alt=\"diskth\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed\">\r\n\r\n##
Testing\r\n\r\n1. Go to hosts view and check network and disk charts
(they should be\r\nnormalized per second)\r\n2. Open the host flyout and
check network and disk charts (they should\r\nbe normalized per
second)\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365","sha":"14876726f4f6edd57672644a322e55cd3d2afd6a"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Normalise network and Disk rates for Hosts across time ranges
6 participants
@jennypavlova @apmmachine @elasticmachine @kibana-ci @kibanamachine @mykolaharmash