-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Normalise network and Disk rates for Hosts across time ranges #164152
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Hey @smith, I had some internal feedback on the overview that has made me realise 3 of the charts need updating (minor changes to the config) - otherwise they don't really provide value and undermine the fly-out value. Do you think there's any scope to making this change and back-porting to 8.10? If possible, I'd like to add one more chart to the overview as well (it's something which is going into the detail view anyway)?
|
Yes probably if we're fixing the normalization
This would probably be something we should not backport. |
Great - thanks @smith. Could I leave it with you to try and get it done before 8.10 goes out?
Could you share your thinking here (if only I can understand what is a good/bad candidate for back-porting in the future)? Would love to get this in here because it's a really important use case: If it can't/shouldn't be done though, I'll respect your judgement on this... |
Following the Kibana guidelines:
Adding one more chart is not a bug fix, it's a feature. |
Cool - thanks @smith. This is really helpful. I understand your thinking now so supportive of that. Will leave the new chart for 8.11... |
…ges (#165680) Closes #164152 ## Summary This PR normalizes the disk and network charts per second. The charts changed: Disk IOPS (read/write) <img width="390" alt="diskiops" src="https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e"> Network (rx/tx) <img width="402" alt="network" src="https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a"> Disk Throughput (read/write) <img width="590" alt="diskth" src="https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed"> ## Testing 1. Go to hosts view and check network and disk charts (they should be normalized per second) 2. Open the host flyout and check network and disk charts (they should be normalized per second) https://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365
…ges (elastic#165680) Closes elastic#164152 ## Summary This PR normalizes the disk and network charts per second. The charts changed: Disk IOPS (read/write) <img width="390" alt="diskiops" src="https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e"> Network (rx/tx) <img width="402" alt="network" src="https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a"> Disk Throughput (read/write) <img width="590" alt="diskth" src="https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed"> ## Testing 1. Go to hosts view and check network and disk charts (they should be normalized per second) 2. Open the host flyout and check network and disk charts (they should be normalized per second) https://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365 (cherry picked from commit 1487672)
…ime ranges (#165680) (#165836) # Backport This will backport the following commits from `main` to `8.10`: - [[Infra UI] Normalise network and Disk rates for Hosts across time ranges (#165680)](#165680) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-06T11:30:51Z","message":"[Infra UI] Normalise network and Disk rates for Hosts across time ranges (#165680)\n\nCloses #164152 \r\n\r\n## Summary\r\n\r\nThis PR normalizes the disk and network charts per second. The charts\r\nchanged:\r\nDisk IOPS (read/write) \r\n<img width=\"390\" alt=\"diskiops\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e\">\r\nNetwork (rx/tx)\r\n<img width=\"402\" alt=\"network\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a\">\r\nDisk Throughput (read/write)\r\n<img width=\"590\" alt=\"diskth\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed\">\r\n\r\n## Testing\r\n\r\n1. Go to hosts view and check network and disk charts (they should be\r\nnormalized per second)\r\n2. Open the host flyout and check network and disk charts (they should\r\nbe normalized per second)\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365","sha":"14876726f4f6edd57672644a322e55cd3d2afd6a","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.11.0"],"number":165680,"url":"https://github.com/elastic/kibana/pull/165680","mergeCommit":{"message":"[Infra UI] Normalise network and Disk rates for Hosts across time ranges (#165680)\n\nCloses #164152 \r\n\r\n## Summary\r\n\r\nThis PR normalizes the disk and network charts per second. The charts\r\nchanged:\r\nDisk IOPS (read/write) \r\n<img width=\"390\" alt=\"diskiops\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e\">\r\nNetwork (rx/tx)\r\n<img width=\"402\" alt=\"network\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a\">\r\nDisk Throughput (read/write)\r\n<img width=\"590\" alt=\"diskth\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed\">\r\n\r\n## Testing\r\n\r\n1. Go to hosts view and check network and disk charts (they should be\r\nnormalized per second)\r\n2. Open the host flyout and check network and disk charts (they should\r\nbe normalized per second)\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365","sha":"14876726f4f6edd57672644a322e55cd3d2afd6a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165680","number":165680,"mergeCommit":{"message":"[Infra UI] Normalise network and Disk rates for Hosts across time ranges (#165680)\n\nCloses #164152 \r\n\r\n## Summary\r\n\r\nThis PR normalizes the disk and network charts per second. The charts\r\nchanged:\r\nDisk IOPS (read/write) \r\n<img width=\"390\" alt=\"diskiops\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/d0993032-7309-4fb9-9e4e-0e9bce73e89e\">\r\nNetwork (rx/tx)\r\n<img width=\"402\" alt=\"network\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/33b20570-60ca-48ef-839b-0363bcccd24a\">\r\nDisk Throughput (read/write)\r\n<img width=\"590\" alt=\"diskth\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/115eba5a-7d46-4846-8f88-fe041b4cfeed\">\r\n\r\n## Testing\r\n\r\n1. Go to hosts view and check network and disk charts (they should be\r\nnormalized per second)\r\n2. Open the host flyout and check network and disk charts (they should\r\nbe normalized per second)\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/14139027/087cd044-b6cc-4612-8fca-391a96848365","sha":"14876726f4f6edd57672644a322e55cd3d2afd6a"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
🔗 Key Links
Issues
Related
Issues/Tasks
📖 Description
Update Network RX/TX and Disk throughput/IOPS metrics to be normalised across different durations to allow SREs to compare them across different durations in Host List, fly-outs and detail view.
Background
When SREs look across different time periods, they need a consistent metrics to allow them to be able to compare the same metric across different durations.
The following metrics are not normalised in way which makes them comparable across different length durations (across both the Host List, fly-out and detail view):
Disk IOPS (read/write) (docs)
Fly-out
Disk Throughput (read/write) (docs)
Fly-out
Network (RX/TX) (docs)
Host Fly-out
Host List
💡 Solution
For normalising all of the metrics, apply the per second normalisation to all of the above in the lens charts:
✔️ Acceptance criteria
1. Must Have
Must be delivered in this issue in order for the release to be valuable
2. Should Have
3. Could Have
Would be nice to have but not critical
4. Will Not Have (for now)
Explicitly will not be looked at within this issue
📈 Telemetry Process
The text was updated successfully, but these errors were encountered: