-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Introducing PLI testing on AET Cypress tests for serverless #165254
Merged
MadameSheema
merged 5 commits into
elastic:main
from
MadameSheema:cypress/introducing-plis
Aug 31, 2023
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
09a82da
adding security,endpoint and cloud complete as default PLI
MadameSheema c0b4f9d
adding test as example
MadameSheema 13d43ce
updating readme
MadameSheema 03e6de0
Merge branch 'main' into cypress/introducing-plis
MadameSheema 543871e
finishing an incomplete sentence
MadameSheema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
...on_cypress/cypress/e2e/explore/dashboards/entity_analytics_serverless_splash_screen.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { login, visit } from '../../../tasks/login'; | ||
|
||
import { ENTITY_ANALYTICS_URL } from '../../../urls/navigation'; | ||
|
||
import { PAYWALL_DESCRIPTION } from '../../../screens/entity_analytics_serverless_splash'; | ||
|
||
describe( | ||
'Entity Analytics Dashboard in Serverless', | ||
{ | ||
tags: '@serverless', | ||
env: { | ||
ftrConfig: { | ||
productTypes: [ | ||
{ product_line: 'security', product_tier: 'essentials' }, | ||
{ product_line: 'endpoint', product_tier: 'essentials' }, | ||
], | ||
}, | ||
}, | ||
}, | ||
() => { | ||
beforeEach(() => { | ||
login(); | ||
visit(ENTITY_ANALYTICS_URL); | ||
}); | ||
|
||
it('should display a splash screen when visited with Security essentials PLI ', () => { | ||
cy.get(PAYWALL_DESCRIPTION).should( | ||
'have.text', | ||
'Entity risk scoring capability is available in our Security Complete license tier' | ||
); | ||
}); | ||
} | ||
); |
8 changes: 8 additions & 0 deletions
8
x-pack/test/security_solution_cypress/cypress/screens/entity_analytics_serverless_splash.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
export const PAYWALL_DESCRIPTION = '[data-test-subj="paywallCardDescription"]'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is confusing to me. Should I update
serverless_config.ts
or not? If not, which file do I need to update?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment @machadoum!! I wanted to say:
Seems that I was tired and I didn't write the sentence properly. Can you please let me know if is clear now? Thanks!! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Thank you!