[Security Solution] Introducing PLI testing on AET Cypress tests for serverless #165254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
changed the title
MadameSheema
added
v8.11.0
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
machadoum
approved these changes
Aug 31, 2023
|
|
||
| Per the way we set the environment during the execution process on CI, the above configuration is going to be valid when the test is executed on headless mode. | ||
|
|
||
| For test developing or test debugging purposes, you need to modify the configuration but without the changes in `x-pack/test/security_solution_cypress/serverless_config.ts` |
There was a problem hiding this comment.
... you need to modify the configuration but without the changes in
x-pack/test/security_solution_cypress/serverless_config.ts
This part is confusing to me. Should I update serverless_config.ts or not? If not, which file do I need to update?
There was a problem hiding this comment.
Thanks for the comment @machadoum!! I wanted to say:
For test developing or test debugging purposes, you need to modify the configuration but without committing and pushing the changes in `x-pack/test/security_solution_cypress/serverless_config.ts`
Seems that I was tired and I didn't write the sentence properly. Can you please let me know if is clear now? Thanks!! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are introducing PLI testing on AET cypress tests for serverless.