Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Move rules up in security solutions menu #165061

Merged
merged 2 commits into from
Aug 29, 2023
Merged

[Security Solutions] Move rules up in security solutions menu #165061

merged 2 commits into from
Aug 29, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Aug 29, 2023 •
edited by kibanamachine
Loading

Summary

Move rules menu item up in security solutions menu.

ESS security menu

Screenshot 2023-08-29 at 09 56 36

ESS Global menu

Screenshot 2023-08-29 at 09 56 51

Serverless

Screenshot 2023-08-29 at 09 49 45

Checklist

@machadoum machadoum self-assigned this Aug 29, 2023
@machadoum machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore enhancement New value added to drive a business result labels Aug 29, 2023
@machadoum machadoum marked this pull request as ready for review August 29, 2023 09:22
@machadoum machadoum requested review from a team as code owners August 29, 2023 09:22
@machadoum machadoum requested a review from spong August 29, 2023 09:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

semd
semd approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PhilippeOberti
PhilippeOberti approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB -32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 924c627 into elastic:main Aug 29, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.10 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.10:
- [Security Solution] Coverage Overview follow-up 2 (#164986)

Manual backport

To create the backport manually run:

node scripts/backport --pr 165061

Questions ?

Please refer to the Backport tool documentation

@machadoum machadoum mentioned this pull request Aug 29, 2023
Merged
@machadoum
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

machadoum added a commit to machadoum/kibana that referenced this pull request Aug 29, 2023
@machadoum
[Security Solutions] Move rules up in security solutions menu (elasti…
468a45d 
…c#165061)

## Summary

Move rules menu item up in security solutions menu.

### ESS security menu
<img width="246" alt="Screenshot 2023-08-29 at 09 56 36"
src="https://github.com/elastic/kibana/assets/1490444/4e0289a8-36bd-41de-b1e9-bbf3704659b0">

### ESS Global menu
<img width="237" alt="Screenshot 2023-08-29 at 09 56 51"
src="https://github.com/elastic/kibana/assets/1490444/63ab1edf-783d-4d89-94b9-2eb257f0e31f">

### Serverless
<img width="251" alt="Screenshot 2023-08-29 at 09 49 45"
src="https://github.com/elastic/kibana/assets/1490444/43902dd1-f6fb-422a-9760-8a25d4593b5c">

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 924c627)

# Conflicts:
#	x-pack/plugins/security_solution/public/explore/links.ts
#	x-pack/plugins/security_solution/public/rules/links.ts
#	x-pack/plugins/security_solution/public/timelines/links.ts
@machadoum machadoum added the bug Fixes for quality problems that affect the customer experience label Aug 29, 2023
machadoum added a commit that referenced this pull request Aug 29, 2023
@machadoum
[8.10] [Security Solutions] Move rules up in security solutions menu (#…
2fbe5ab 
…165061) (#165082)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solutions] Move rules up in security solutions menu
(#165061)](#165061)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-29T11:05:44Z","message":"[Security
Solutions] Move rules up in security solutions menu (#165061)\n\n##
Summary\r\n\r\nMove rules menu item up in security solutions
menu.\r\n\r\n### ESS security menu\r\n<img width=\"246\"
alt=\"Screenshot 2023-08-29 at 09 56
36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/4e0289a8-36bd-41de-b1e9-bbf3704659b0\">\r\n\r\n###
ESS Global menu\r\n<img width=\"237\" alt=\"Screenshot 2023-08-29 at 09
56
51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/63ab1edf-783d-4d89-94b9-2eb257f0e31f\">\r\n\r\n###
Serverless\r\n<img width=\"251\" alt=\"Screenshot 2023-08-29 at 09 49
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/43902dd1-f6fb-422a-9760-8a25d4593b5c\">\r\n\r\n\r\n###
Checklist\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"924c627f16e6cb9d4b9f06856f4f6548e90ba279","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","enhancement","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.10.0","v8.11.0"],"number":165061,"url":"https://github.com/elastic/kibana/pull/165061","mergeCommit":{"message":"[Security
Solutions] Move rules up in security solutions menu (#165061)\n\n##
Summary\r\n\r\nMove rules menu item up in security solutions
menu.\r\n\r\n### ESS security menu\r\n<img width=\"246\"
alt=\"Screenshot 2023-08-29 at 09 56
36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/4e0289a8-36bd-41de-b1e9-bbf3704659b0\">\r\n\r\n###
ESS Global menu\r\n<img width=\"237\" alt=\"Screenshot 2023-08-29 at 09
56
51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/63ab1edf-783d-4d89-94b9-2eb257f0e31f\">\r\n\r\n###
Serverless\r\n<img width=\"251\" alt=\"Screenshot 2023-08-29 at 09 49
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/43902dd1-f6fb-422a-9760-8a25d4593b5c\">\r\n\r\n\r\n###
Checklist\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"924c627f16e6cb9d4b9f06856f4f6548e90ba279"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165061","number":165061,"mergeCommit":{"message":"[Security
Solutions] Move rules up in security solutions menu (#165061)\n\n##
Summary\r\n\r\nMove rules menu item up in security solutions
menu.\r\n\r\n### ESS security menu\r\n<img width=\"246\"
alt=\"Screenshot 2023-08-29 at 09 56
36\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/4e0289a8-36bd-41de-b1e9-bbf3704659b0\">\r\n\r\n###
ESS Global menu\r\n<img width=\"237\" alt=\"Screenshot 2023-08-29 at 09
56
51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/63ab1edf-783d-4d89-94b9-2eb257f0e31f\">\r\n\r\n###
Serverless\r\n<img width=\"251\" alt=\"Screenshot 2023-08-29 at 09 49
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1490444/43902dd1-f6fb-422a-9760-8a25d4593b5c\">\r\n\r\n\r\n###
Checklist\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"924c627f16e6cb9d4b9f06856f4f6548e90ba279"}}]}]
BACKPORT-->
@nastasha-solomon nastasha-solomon mentioned this pull request Sep 4, 2023
Merged
@natasha-moore-elastic natasha-moore-elastic mentioned this pull request Sep 7, 2023
Closed
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanSh JordanSh JordanSh approved these changes

@semd semd semd approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@jpdjere jpdjere jpdjere approved these changes

@spong spong Awaiting requested review from spong spong was automatically assigned from elastic/security-detection-rule-management

Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @jpdjere @PhilippeOberti @semd @JordanSh