Skip to content

Commit

Permalink
[Security Solutions] Move rules up in security solutions menu (#165061)
Browse files Browse the repository at this point in the history
## Summary

Move rules menu item up in security solutions menu.

### ESS security menu
<img width="246" alt="Screenshot 2023-08-29 at 09 56 36"
src="https://github.com/elastic/kibana/assets/1490444/4e0289a8-36bd-41de-b1e9-bbf3704659b0">

### ESS Global menu
<img width="237" alt="Screenshot 2023-08-29 at 09 56 51"
src="https://github.com/elastic/kibana/assets/1490444/63ab1edf-783d-4d89-94b9-2eb257f0e31f">

### Serverless
<img width="251" alt="Screenshot 2023-08-29 at 09 49 45"
src="https://github.com/elastic/kibana/assets/1490444/43902dd1-f6fb-422a-9760-8a25d4593b5c">


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
machadoum authored Aug 29, 2023
1 parent edef2e2 commit 924c627
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/cases/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const casesLinks = getCasesDeepLinks<LinkItem>({
basePath: CASES_PATH,
extend: {
[SecurityPageName.case]: {
globalNavPosition: 4,
globalNavPosition: 5,
capabilities: [`${CASES_FEATURE_ID}.${READ_CASES_CAPABILITY}`],
},
[SecurityPageName.caseConfigure]: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const commonLinkProperties: Partial<LinkItem> = {

export const findingsLinks: LinkItem = {
...getSecuritySolutionLink<SecurityPageName>('findings'),
globalNavPosition: 3,
globalNavPosition: 4,
...commonLinkProperties,
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const CATEGORIES: SeparatorLinkCategory[] = [
{
type: LinkCategoryType.separator,
linkIds: [
SecurityPageName.rulesLanding,
SecurityPageName.alerts,
SecurityPageName.cloudSecurityPostureFindings,
SecurityPageName.case,
Expand All @@ -29,8 +30,4 @@ export const CATEGORIES: SeparatorLinkCategory[] = [
SecurityPageName.exploreLanding,
],
},
{
type: LinkCategoryType.separator,
linkIds: [SecurityPageName.rulesLanding],
},
];
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const links: LinkItem = {
title: ALERTS,
path: ALERTS_PATH,
capabilities: [`${SERVER_APP_ID}.show`],
globalNavPosition: 2,
globalNavPosition: 3,
globalSearchKeywords: [
i18n.translate('xpack.securitySolution.appLinks.alerts', {
defaultMessage: 'Alerts',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/explore/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export const exploreLinks: LinkItem = {
id: SecurityPageName.exploreLanding,
title: EXPLORE,
path: EXPLORE_PATH,
globalNavPosition: 7,
globalNavPosition: 8,
capabilities: [`${SERVER_APP_ID}.show`],
globalSearchKeywords: [
i18n.translate('xpack.securitySolution.appLinks.explore', {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/rules/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const links: LinkItem = {
path: RULES_LANDING_PATH,
hideTimeline: true,
skipUrlState: true,
globalNavPosition: 8,
globalNavPosition: 2,
capabilities: [`${SERVER_APP_ID}.show`],
links: [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ import type { LinkItem } from '../common/links';
*/
export const indicatorsLinks: LinkItem = {
...getSecuritySolutionLink<SecurityPageName>('indicators'),
globalNavPosition: 6,
globalNavPosition: 7,
capabilities: [`${SERVER_APP_ID}.threat-intelligence`],
};
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/timelines/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const links: LinkItem = {
id: SecurityPageName.timelines,
title: TIMELINES,
path: TIMELINES_PATH,
globalNavPosition: 5,
globalNavPosition: 6,
capabilities: [`${SERVER_APP_ID}.show`],
globalSearchKeywords: [
i18n.translate('xpack.securitySolution.appLinks.timelines', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const CATEGORIES: SeparatorLinkCategory[] = [
{
type: LinkCategoryType.separator,
linkIds: [
SecurityPageName.rulesLanding,
SecurityPageName.alerts,
SecurityPageName.cloudSecurityPostureFindings,
SecurityPageName.case,
Expand All @@ -35,7 +36,7 @@ export const CATEGORIES: SeparatorLinkCategory[] = [
},
{
type: LinkCategoryType.separator,
linkIds: [ExternalPageName.fleet, SecurityPageName.assets, SecurityPageName.rulesLanding],
linkIds: [ExternalPageName.fleet, SecurityPageName.assets],
},
{
type: LinkCategoryType.separator,
Expand Down

0 comments on commit 924c627

Please sign in to comment.