[data views] fix fields for wildcard integration test #164772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
davismcphee
approved these changes
Aug 24, 2023
| aggregatable: true, | ||
| searchable: true, | ||
| readFromDocValues: false, | ||
| readFromDocValues: true, |
There was a problem hiding this comment.
Do we know why readFromDocValues changed?
mattkime
changed the title
mattkime
added
Feature:Data Views
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
mattkime
added
the
release_note:skip
kibanamachine
added
v8.11.0
backport:skip
davismcphee
added a commit
to davismcphee/kibana
that referenced
this pull request
Aug 28, 2023
davismcphee
pushed a commit
to davismcphee/kibana
that referenced
this pull request
Sep 6, 2023
I'm waiting for this to fail CI - this means that a new ES snapshot is being used. Then we update the test snapshot and should be good to merge. The lastest ES snapshot is returning field types in a different order which really doesn't matter to this endpoint so I'll just update the snapshot. Closes elastic#164753
davismcphee
added a commit
that referenced
this pull request
Sep 15, 2023
) Cherry picked from #164772: > ## Summary > I'm waiting for this to fail CI - this means that a new ES snapshot is being used. Then we update the test snapshot and should be good to merge. > > The lastest ES snapshot is returning field types in a different order which really doesn't matter to this endpoint so I'll just update the snapshot. Closes #165633. --------- Co-authored-by: Matthew Kime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm waiting for this to fail CI - this means that a new ES snapshot is being used. Then we update the test snapshot and should be good to merge.
The lastest ES snapshot is returning field types in a different order which really doesn't matter to this endpoint so I'll just update the snapshot.
Closes #164753