Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing ES Forward Compatibility: API Integration Tests / apis index_patterns index_patterns/_fields_for_wildcard route conflicts flags fields with mismatched types as conflicting #165633

Closed
mistic opened this issue Sep 5, 2023 · 7 comments · Fixed by #165910
Closed

Failing ES Forward Compatibility: API Integration Tests / apis index_patterns index_patterns/_fields_for_wildcard route conflicts flags fields with mismatched types as conflicting #165633

mistic opened this issue Sep 5, 2023 · 7 comments · Fixed by #165910
Assignees
@davismcphee
Labels
failed-es-promotion Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mistic
Copy link
Member

mistic commented Sep 5, 2023

API Integration Tests
test/api_integration/apis/index_patterns/fields_for_wildcard_route/conflicts.js

apis index_patterns index_patterns/_fields_for_wildcard route conflicts flags fields with mismatched types as conflicting

This failure is preventing the ES 8.11 forward compatibility pipeline to proceed.

Error: expected { fields: 
   [ { name: '@timestamp',
       type: 'date',
       esTypes: [Object],
       searchable: true,
       aggregatable: true,
       readFromDocValues: true,
       metadata_field: false },
     { name: 'number_conflict',
       type: 'number',
       esTypes: [Object],
       searchable: true,
       aggregatable: true,
       readFromDocValues: true,
       metadata_field: false },
     { name: 'string_conflict',
       type: 'string',
       esTypes: [Object],
       searchable: true,
       aggregatable: true,
       readFromDocValues: true,
       metadata_field: false },
     { name: 'success',
       type: 'conflict',
       esTypes: [Object],
       searchable: true,
       aggregatable: true,
       readFromDocValues: false,
       conflictDescriptions: [Object],
       metadata_field: false } ] } to sort of equal { fields: 
   [ { name: '@timestamp',
       type: 'date',
       esTypes: [Object],
       aggregatable: true,
       searchable: true,
       readFromDocValues: true,
       metadata_field: false },
     { name: 'number_conflict',
       type: 'number',
       esTypes: [Object],
       aggregatable: true,
       searchable: true,
       readFromDocValues: true,
       metadata_field: false },
     { name: 'string_conflict',
       type: 'string',
       esTypes: [Object],
       aggregatable: true,
       searchable: true,
       readFromDocValues: false,
       metadata_field: false },
     { name: 'success',
       type: 'conflict',
       esTypes: [Object],
       aggregatable: true,
       searchable: true,
       readFromDocValues: false,
       conflictDescriptions: [Object],
       metadata_field: false } ] }
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (node_modules/@kbn/expect/expect.js:244:8)
    at /opt/local-ssd/buildkite/builds/kb-n2-2-a3a9665cc19b0c63/elastic/kibana-7-dot-17-es-8-dot-11-forward-compatibility/kibana/test/api_integration/apis/index_patterns/fields_for_wildcard_route/conflicts.js:29:32
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:78:16) {
  actual: '{\n' +
    '  "fields": [\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "esTypes": [\n' +
    '        "date"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "@timestamp"\n' +
    '      "readFromDocValues": true\n' +
    '      "searchable": true\n' +
    '      "type": "date"\n' +
    '    }\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "esTypes": [\n' +
    '        "float"\n' +
    '        "integer"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "number_conflict"\n' +
    '      "readFromDocValues": true\n' +
    '      "searchable": true\n' +
    '      "type": "number"\n' +
    '    }\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "esTypes": [\n' +
    '        "keyword"\n' +
    '        "text"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "string_conflict"\n' +
    '      "readFromDocValues": true\n' +
    '      "searchable": true\n' +
    '      "type": "string"\n' +
    '    }\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "conflictDescriptions": {\n' +
    '        "boolean": [\n' +
    '          "logs-2017.01.02"\n' +
    '        ]\n' +
    '        "keyword": [\n' +
    '          "logs-2017.01.01"\n' +
    '        ]\n' +
    '      }\n' +
    '      "esTypes": [\n' +
    '        "keyword"\n' +
    '        "boolean"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "success"\n' +
    '      "readFromDocValues": false\n' +
    '      "searchable": true\n' +
    '      "type": "conflict"\n' +
    '    }\n' +
    '  ]\n' +
    '}',
  expected: '{\n' +
    '  "fields": [\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "esTypes": [\n' +
    '        "date"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "@timestamp"\n' +
    '      "readFromDocValues": true\n' +
    '      "searchable": true\n' +
    '      "type": "date"\n' +
    '    }\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "esTypes": [\n' +
    '        "integer"\n' +
    '        "float"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "number_conflict"\n' +
    '      "readFromDocValues": true\n' +
    '      "searchable": true\n' +
    '      "type": "number"\n' +
    '    }\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "esTypes": [\n' +
    '        "text"\n' +
    '        "keyword"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "string_conflict"\n' +
    '      "readFromDocValues": false\n' +
    '      "searchable": true\n' +
    '      "type": "string"\n' +
    '    }\n' +
    '    {\n' +
    '      "aggregatable": true\n' +
    '      "conflictDescriptions": {\n' +
    '        "boolean": [\n' +
    '          "logs-2017.01.02"\n' +
    '        ]\n' +
    '        "keyword": [\n' +
    '          "logs-2017.01.01"\n' +
    '        ]\n' +
    '      }\n' +
    '      "esTypes": [\n' +
    '        "boolean"\n' +
    '        "keyword"\n' +
    '      ]\n' +
    '      "metadata_field": false\n' +
    '      "name": "success"\n' +
    '      "readFromDocValues": false\n' +
    '      "searchable": true\n' +
    '      "type": "conflict"\n' +
    '    }\n' +
    '  ]\n' +
    '}',
  showDiff: true
}
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 5, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 5, 2023
mistic added a commit that referenced this issue Sep 5, 2023
@mistic
skip failing es forward compatibility suite (#165633)
bfbbb93
@mistic
Copy link
Member Author

mistic commented Sep 5, 2023

Skipped.

7.17: bfbbb93

@rayafratkina
Copy link
Contributor

@petrklapka @vadimkibana - can somebody take a look asap, please?

@vadimkibana vadimkibana added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Sep 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@vadimkibana
Copy link
Contributor

Changed team to Data Discover as I believe index patterns are maintained by that team.

@davismcphee davismcphee added loe:needs-research This issue requires some research before it can be worked on or estimated impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Sep 6, 2023
@davismcphee
Copy link
Contributor

Yup this is definitely our domain. This appears to be the same failure as #164753, likely the same fix too. Looking now into cherry picking the fix from #164772 to the 7.17 branch. cc @mattkime

@davismcphee davismcphee self-assigned this Sep 6, 2023
@davismcphee davismcphee mentioned this issue Sep 6, 2023
Merged
@davismcphee
Copy link
Contributor

@mistic I created a PR targeting 7.17 with a fix for this (#165910) and confirmed that it passed locally when running against an ES 8.11 instance, but it fails in CI presumably because it's not running ES 8.11. I'm not sure how to proceed here. Do you have any guidance on what to do next?

davismcphee added a commit that referenced this issue Sep 15, 2023
@davismcphee @mattkime
[7.17.14] [data views] fix fields for wildcard integration test (#165910
246fc4b 
)

Cherry picked from #164772:
> ## Summary
> I'm waiting for this to fail CI - this means that a new ES snapshot is
being used. Then we update the test snapshot and should be good to
merge.
> 
> The lastest ES snapshot is returning field types in a different order
which really doesn't matter to this endpoint so I'll just update the
snapshot.

Closes #165633.

---------

Co-authored-by: Matthew Kime <[email protected]>
@davismcphee davismcphee linked a pull request Sep 15, 2023 that will close this issue
[7.17.14] [data views] fix fields for wildcard integration test #165910
Merged
@davismcphee
Copy link
Contributor

Fixed by #165910.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davismcphee davismcphee

Labels
failed-es-promotion Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[7.17.14] [data views] fix fields for wildcard integration test davismcphee/kibana
6 participants
@mistic @elasticmachine @davismcphee @rayafratkina @kibanamachine @vadimkibana