-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log Explorer] Convert log explorer profile into standalone app #164493
Merged
Merged
Changes from 52 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
fc04346
Rename the plugin
weltenwort 3d077e2
Add observability_log_explorer plugin
weltenwort 6b32955
Add obs log explorer server-side
weltenwort 39b1440
Achieve basic log explorer rendering
weltenwort 87cd1e5
Hide the nav entry for now
weltenwort 4fee709
Wrap with obs page template
weltenwort 15f9300
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 41de574
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine a77ee87
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine 6b24b5c
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 76ef9c9
Merge branch 'main' into log-explorer-app
weltenwort c676985
Make deep link searchable
weltenwort f5fb017
Add stateful log explorer link
weltenwort 1d7ff78
Merge branch 'main' into log-explorer-app
weltenwort 3e9f0c0
Add breadcrumbs
weltenwort c49a4d7
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 7904041
Fix filter control height and clipping
weltenwort eeeceac
Prevent enabling the search session service
weltenwort 7067550
Add to serverless nav
weltenwort 4198a44
Start to fix the functional tests
weltenwort b894bf9
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine f89e674
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine ebc7d26
Merge branch 'main' into log-explorer-app
weltenwort 7277e81
Initialize bundle limits
weltenwort 7ac3a3b
Fix stateful functional tests
weltenwort 9482dcb
Fix serverless function tests
weltenwort d795bb3
Move nav link setting
weltenwort 3b57f3a
Fix translation prefix
weltenwort b94f54b
Fix application usage tracking schema
weltenwort 50e5dca
Fix functional test navigation method
weltenwort fe12e04
Restore global search test to pre-profile state
weltenwort 14b886e
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 75030fa
Fix telemetry schema
weltenwort ba729df
Fix test for exposed config keys
weltenwort 15a3548
Fix cypress e2e test
weltenwort d6d44a1
Merge branch 'main' into log-explorer-app
weltenwort 4a1f197
Merge branch 'main' into log-explorer-app
weltenwort a321268
Fix serverless navigation tests
weltenwort 2b2e27a
Merge branch 'main' into log-explorer-app
weltenwort 5d07c88
Fix serverless log explorer nav tests
weltenwort 4e9e6e7
Merge branch 'main' into log-explorer-app
weltenwort 59cca71
Merge branch 'main' into log-explorer-app
weltenwort 6a5c8d4
Temporarily skip tests relying on broken utils
weltenwort fbaf210
Adapt to upstream Discover component changes
weltenwort ec68602
Adapt functional tests to routing changes
weltenwort 288a565
Merge branch 'main' into log-explorer-app
weltenwort b8f07e6
Unskip test
weltenwort d88e36e
Update x-pack/plugins/log_explorer/kibana.jsonc
weltenwort f983021
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 23d8879
Add a basic description to the plugin README
weltenwort 7cf2129
Remove unused config types
weltenwort 9906a21
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 204264c
Merge branch 'main' into log-explorer-app
weltenwort b192889
Add comment to conditional config key in test
weltenwort d8e572c
Remove superfluous test fixtures
weltenwort 7fc1039
Merge branch 'main' into log-explorer-app
weltenwort b97c53d
Add beta badge to chrome
weltenwort File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,5 @@ | |
"target/**/*" | ||
], | ||
"kbn_references": [ | ||
"@kbn/deeplinks-analytics", | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should this be of type
(boolean)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried. The test expects
any
- possibly because it loses the type due to the serverless guard.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weltenwort Could you add a short comment to explain the
any
type? I know we don't have them for all of theany
-typed items here, but we're trying to be better about this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course, done