-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log Explorer] Convert log explorer profile into standalone app #164493
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…-ref HEAD~1..HEAD --fix'
This comment was marked as outdated.
This comment was marked as outdated.
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM. Just one minor nit/ask.
* xpack.discoverLogExplorer.featureFlags is conditional and will never resolve if used in non-serverless environment | ||
*/ | ||
'xpack.discoverLogExplorer.featureFlags.deepLinkVisible (any)', | ||
'xpack.observabilityLogExplorer.navigation.showAppLink (any)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weltenwort Could you add a short comment to explain the any
type? I know we don't have them for all of the any
-typed items here, but we're trying to be better about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limits.yml, storybook aliases lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes LGTM and the features still work correctly, thanks for this work 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-pack/test_serverless/functional/config.base.ts
changes LGTM
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @weltenwort |
📝 Summary
This converts the log explorer profile into a stand-alone log explorer component and an observability log explorer app, that uses it.
closes #164197
Release note
The Observability Log Explorer App is made available as a preview in the Observability solution navigation. It offers the usability of Discover, but is optimized for viewing log entries from log data streams.
🛠️ Implementation notes
discover_log_explorer
plugin intolog_explorer
.log_explorer
now exports a component that renders theDiscoverContainer
with the previously implemented customizations. This is where integration-level customization will go in the future. For observability-specific customizations this component will have to become a lot more configurable.observability_log_explorer
registers a log explorer application, which renders the aforementioned log explorer component. This is where observability-specific customizations will go in the future.🎨 Previews
Stateful
/app/observability-log-explorer
Stateless
/app/observability-log-explorer