Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Updates codeowners file #164026

Merged
merged 2 commits into from
Aug 16, 2023
Merged

[Security Solution] Updates codeowners file #164026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d29cc6
updates codeowners file
MadameSheema Aug 16, 2023
0db5f78
Merge branch 'main' into updating-codeowners
MadameSheema Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,11 @@ x-pack/plugins/security_solution/server/lib/telemetry/ @elastic/security-data-an

## Security Solution sub teams - security-engineering-productivity
x-pack/test/security_solution_cypress/cypress/README.md @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress/es_archives @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress/cli_config.ts @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress/config.ts @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress/runner.ts @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress/serverless_config.ts @elastic/security-engineering-productivity
Comment on lines +1286 to +1290
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the reason why you were getting assigned as a code owners is because x-pack/test/security_solution_cypress @elastic/security-engineering-productivity was below team-specific cypress folders like /x-pack/plugins/security_solution/common/api/detection_engine/rule_exceptions @elastic/security-detection-engine in the CODEOWNERS file.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file

# Order is important; the last matching pattern takes the most
# precedence. ...

We could also move up the x-pack/test/security_solution_cypress @elastic/security-engineering-productivity line so it's defined in the file above the team-specific folders. That way you'd own everything in x-pack/test/security_solution_cypress except the team-owned folders. Which I'm not sure is what you want.


## Security Solution sub teams - adaptive-workload-protection
x-pack/plugins/security_solution/public/common/components/sessions_viewer @elastic/sec-cloudnative-integrations
Expand Down