[Security Solution] Updates codeowners file #164026
Conversation
MadameSheema
added
release_note:skip
MadameSheema
requested review from
stephmilovic,
banderror,
yctercero,
michaelolo24 and
PhilippeOberti
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
| x-pack/test/security_solution_cypress/es_archives @elastic/security-engineering-productivity | ||
| x-pack/test/security_solution_cypress/cli_config.ts @elastic/security-engineering-productivity | ||
| x-pack/test/security_solution_cypress/config.ts @elastic/security-engineering-productivity | ||
| x-pack/test/security_solution_cypress/runner.ts @elastic/security-engineering-productivity | ||
| x-pack/test/security_solution_cypress/serverless_config.ts @elastic/security-engineering-productivity |
There was a problem hiding this comment.
FWIW the reason why you were getting assigned as a code owners is because x-pack/test/security_solution_cypress @elastic/security-engineering-productivity was below team-specific cypress folders like /x-pack/plugins/security_solution/common/api/detection_engine/rule_exceptions @elastic/security-detection-engine in the CODEOWNERS file.
# Order is important; the last matching pattern takes the most
# precedence. ...
We could also move up the x-pack/test/security_solution_cypress @elastic/security-engineering-productivity line so it's defined in the file above the team-specific folders. That way you'd own everything in x-pack/test/security_solution_cypress except the team-owned folders. Which I'm not sure is what you want.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Originally
security-engineering-productivityteam as owning thex-pack/test/security_solution_cypress/folder since all the configuration related to the FTR server and archives lived there.After moving all the Cypress tests to that folder we missed updating the codeowners file to don't become a bottleneck on any small Cypress change. In this PR we are doing that by owning just those that might be relevant.