[Security Solution] Fix CODEOWNERS for Detection and Response teams #163964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
technical debt
oatkiller
approved these changes
Aug 15, 2023
marshallmain
approved these changes
Aug 15, 2023
banderror
force-pushed
the
fix-codeowners-file-for-detection-and-response
branch
from
7eef006 to
ded97b1
Compare
banderror
force-pushed
the
fix-codeowners-file-for-detection-and-response
branch
from
ded97b1 to
fefe42c
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @banderror |
kibanamachine
added
v8.10.0
backport:skip
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
…163964) ## Summary According to @oatkiller, we have many CODEOWNERS rules that match no files. I updated the file according to this and my own audit: ``` $ github-codeowners validate Found duplicate rules [ 'x-pack/packages/observability/alert_details @elastic/actionable-observability' ] Found rules which did not match any files [ 'x-pack/test/alerting_api_integration/common/plugins/aad @elastic/response-ops', 'x-pack/test/alerting_api_integration/common/plugins/actions_simulators @elastic/response-ops', 'x-pack/test/alerting_api_integration/packages/helpers @elastic/response-ops', 'x-pack/test/alerting_api_integration/common/plugins/alerts @elastic/response-ops', 'x-pack/test/alerting_api_integration/common/plugins/alerts_restricted @elastic/response-ops', 'test/analytics/plugins/analytics_ftr_helpers @elastic/kibana-core', 'test/analytics/plugins/analytics_plugin_a @elastic/kibana-core', 'x-pack/test/security_api_integration/plugins/audit_log @elastic/kibana-security', 'x-pack/test/cases_api_integration/common/plugins/cases @elastic/response-ops', 'x-pack/plugins/cloud_defend @elastic/sec-cloudnative-integrations', 'src/plugins/data @elastic/kibana-visualizations @elastic/kibana-data-discovery', 'x-pack/test/encrypted_saved_objects_api_integration/plugins/api_consumer_plugin @elastic/kibana-security', 'x-pack/test/ui_capabilities/common/plugins/foo_plugin @elastic/kibana-security', 'test/interactive_setup_api_integration/plugins/test_endpoints @elastic/kibana-security', 'x-pack/test/cases_api_integration/common/plugins/observability @elastic/response-ops', 'x-pack/test/security_api_integration/plugins/oidc_provider @elastic/kibana-security', 'packages/kbn-performance-testing-dataset-extractor @elastic/kibana-performance-testing', 'packages/react/kibana_context/common @elastic/appex-sharedux', 'packages/react/kibana_context/render @elastic/appex-sharedux', 'packages/react/kibana_context/root @elastic/appex-sharedux', 'packages/react/kibana_context/styled @elastic/appex-sharedux', 'packages/react/kibana_context/theme @elastic/appex-sharedux', 'packages/react/kibana_mount @elastic/appex-sharedux', 'x-pack/test/security_api_integration/plugins/saml_provider @elastic/kibana-security', 'x-pack/test/saved_object_api_integration/common/plugins/saved_object_test_plugin @elastic/kibana-security', 'x-pack/test/security_api_integration/packages/helpers @elastic/kibana-core', 'x-pack/plugins/security_solution_ess @elastic/security-solution', 'x-pack/test/cases_api_integration/common/plugins/security_solution @elastic/response-ops', 'x-pack/plugins/security_solution_serverless @elastic/security-solution', 'x-pack/test/security_functional/plugins/test_endpoints @elastic/kibana-security', 'x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin @elastic/kibana-security', 'x-pack/test/alerting_api_integration/common/plugins/task_manager_fixture @elastic/response-ops', 'x-pack/test/security_api_integration/plugins/user_profiles_consumer @elastic/kibana-security', '/src/plugins/visualize/ @elastic/kibana-visualizations', '/x-pack/test/api_integration/apis/lens/ @elastic/kibana-visualizations', '/x-pack/test/functional/apps/dashboard/reporting/ @elastic/appex-sharedux', '/x-pack/test/functional/es_archives/lens/reporting/ @elastic/appex-sharedux', '/src/plugins/kibana_react/public/@elastic/appex-sharedux @elastic/kibana-presentation', '/.github/workflows/deploy-my-kibana.yml @elastic/observablt-robots', '/.github/workflows/oblt-github-commands @elastic/observablt-robots', '/x-pack/test/api_integration/apis/infra @elastic/infra-monitoring-ui', '/src/dev/build/tasks/bundle_fleet_packages.ts @elastic/fleet @elastic/kibana-operations', '/src/apm.js @elastic/kibana-core @vigneshshanmugam', '/src/core/types/elasticsearch @elastic/apm-ui', '/packages/kbn-utility-types/src/dot_test.ts @dgieselaar', '/x-pack/test/alerting_api_integration/observability/synthetics_rule.ts @elastic/uptime', '/x-pack/test/alerting_api_integration/observability/index.ts @elastic/uptime', '/x-pack/plugins/apm/public/application/uxApp.tsx @elastic/uptime', '/x-pack/plugins/apm/public/components/app/rum_dashboard @elastic/uptime', '/x-pack/test/apm_api_integration/tests/csm/ @elastic/uptime', '/x-pack/test/api_integration_basic/apis/ml/ @elastic/ml-ui', '/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/ml_rule_types/ @elastic/ml-ui', '/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/transform_rule_types/ @elastic/ml-ui', '/x-pack/test/screenshot_creation/services/ml_screenshots.ts @elastic/ml-ui', '/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis', '/src/dev/license_checker/config.ts @elastic/kibana-operations', '/test/visual_regression @elastic/appex-qa', '/x-pack/test/visual_regression @elastic/appex-qa', '/src/core/public/i18n/ @elastic/kibana-localization @elastic/kibana-core', '/x-pack/plugins/security_solution/public/common/components/alerts_viewer @elastic/security-threat-hunting-investigations', '/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_action @elastic/security-threat-hunting-investigations', '/x-pack/plugins/security_solution/public/detections/components/alerts_info @elastic/security-threat-hunting-investigations', '/x-pack/plugins/security_solution/common/search_strategy/security_solution/user @elastic/security-threat-hunting-explore', '/x-pack/plugins/security_solution/cypress/upgrade_e2e/threat_hunting/cases @elastic/security-threat-hunting-explore', '/x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema @elastic/security-detection-rule-management @elastic/security-detection-engine', '/x-pack/plugins/security_solution/common/api/detection_engine/fleet_integrations @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/api/detection_engine/prebuilt_rules @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/api/detection_engine/rule_management @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/api/detection_engine/rule_monitoring @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/detection_engine/fleet_integrations @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/detection_engine/prebuilt_rules @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/detection_engine/rule_monitoring @elastic/security-detection-rule-management', '/x-pack/plugins/security_solution/common/detection_engine/rule_exceptions @elastic/security-detection-engine', '/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions_ui @elastic/security-detection-engine', '/x-pack/plugins/security_solution/public/common/components/exceptions @elastic/security-detection-engine', '/x-pack/plugins/security_solution/server/lib/sourcerer @elastic/security-detection-engine', '/x-pack/plugins/security_solution/cypress/e2e/detection_rules @elastic/security-detection-rule-management @elastic/security-detection-engine', '/x-pack/plugins/security_solution/cypress/plugins @elastic/security-detections-response @elastic/security-threat-hunting', '/x-pack/plugins/security_solution/common/ecs @elastic/security-threat-hunting-investigations', '/x-pack/plugins/security_solution/server/lib/detection_engine/rule_actions @elastic/security-detection-engine @elastic/security-detection-rule-management', 'x-pack/plugins/security_solution/cypress/ccs_e2e @elastic/security-engineering-productivity', 'x-pack/plugins/security_solution/cypress/upgrade_e2e @elastic/security-engineering-productivity', '/x-pack/plugins/security_solution/common/detection_engine/rule_response_actions @elastic/security-defend-workflows', '/x-pack/plugins/security_solution/public/common/components/guided_onboarding @elastic/security-threat-hunting-explore', '/x-pack/plugins/apm/**/*.scss @elastic/observability-design', '/x-pack/plugins/endpoint/**/*.scss @elastic/security-design', '/x-pack/plugins/security_solution_ess/**/*.scss @elastic/security-design', '/x-pack/plugins/security_solution_serverless/**/*.scss @elastic/security-design' ] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to @oatkiller, we have many CODEOWNERS rules that match no files.
I updated the file according to this and my own audit: