Skip to content

Commit

Permalink
[Security Solution] Fix CODEOWNERS for Detection and Response teams (#…
Browse files Browse the repository at this point in the history 
…163964)

## Summary

According to @oatkiller, we have many CODEOWNERS rules that match no
files.

I updated the file according to this and my own audit:

```
$ github-codeowners validate
Found duplicate rules [
  'x-pack/packages/observability/alert_details @elastic/actionable-observability'
]
Found rules which did not match any files [
  'x-pack/test/alerting_api_integration/common/plugins/aad @elastic/response-ops',
  'x-pack/test/alerting_api_integration/common/plugins/actions_simulators @elastic/response-ops',
  'x-pack/test/alerting_api_integration/packages/helpers @elastic/response-ops',
  'x-pack/test/alerting_api_integration/common/plugins/alerts @elastic/response-ops',
  'x-pack/test/alerting_api_integration/common/plugins/alerts_restricted @elastic/response-ops',
  'test/analytics/plugins/analytics_ftr_helpers @elastic/kibana-core',
  'test/analytics/plugins/analytics_plugin_a @elastic/kibana-core',
  'x-pack/test/security_api_integration/plugins/audit_log @elastic/kibana-security',
  'x-pack/test/cases_api_integration/common/plugins/cases @elastic/response-ops',
  'x-pack/plugins/cloud_defend @elastic/sec-cloudnative-integrations',
  'src/plugins/data @elastic/kibana-visualizations @elastic/kibana-data-discovery',
  'x-pack/test/encrypted_saved_objects_api_integration/plugins/api_consumer_plugin @elastic/kibana-security',
  'x-pack/test/ui_capabilities/common/plugins/foo_plugin @elastic/kibana-security',
  'test/interactive_setup_api_integration/plugins/test_endpoints @elastic/kibana-security',
  'x-pack/test/cases_api_integration/common/plugins/observability @elastic/response-ops',
  'x-pack/test/security_api_integration/plugins/oidc_provider @elastic/kibana-security',
  'packages/kbn-performance-testing-dataset-extractor @elastic/kibana-performance-testing',
  'packages/react/kibana_context/common @elastic/appex-sharedux',
  'packages/react/kibana_context/render @elastic/appex-sharedux',
  'packages/react/kibana_context/root @elastic/appex-sharedux',
  'packages/react/kibana_context/styled @elastic/appex-sharedux',
  'packages/react/kibana_context/theme @elastic/appex-sharedux',
  'packages/react/kibana_mount @elastic/appex-sharedux',
  'x-pack/test/security_api_integration/plugins/saml_provider @elastic/kibana-security',
  'x-pack/test/saved_object_api_integration/common/plugins/saved_object_test_plugin @elastic/kibana-security',
  'x-pack/test/security_api_integration/packages/helpers @elastic/kibana-core',
  'x-pack/plugins/security_solution_ess @elastic/security-solution',
  'x-pack/test/cases_api_integration/common/plugins/security_solution @elastic/response-ops',
  'x-pack/plugins/security_solution_serverless @elastic/security-solution',
  'x-pack/test/security_functional/plugins/test_endpoints @elastic/kibana-security',
  'x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin @elastic/kibana-security',
  'x-pack/test/alerting_api_integration/common/plugins/task_manager_fixture @elastic/response-ops',
  'x-pack/test/security_api_integration/plugins/user_profiles_consumer @elastic/kibana-security',
  '/src/plugins/visualize/ @elastic/kibana-visualizations',
  '/x-pack/test/api_integration/apis/lens/ @elastic/kibana-visualizations',
  '/x-pack/test/functional/apps/dashboard/reporting/ @elastic/appex-sharedux',
  '/x-pack/test/functional/es_archives/lens/reporting/ @elastic/appex-sharedux',
  '/src/plugins/kibana_react/public/@elastic/appex-sharedux @elastic/kibana-presentation',
  '/.github/workflows/deploy-my-kibana.yml @elastic/observablt-robots',
  '/.github/workflows/oblt-github-commands @elastic/observablt-robots',
  '/x-pack/test/api_integration/apis/infra @elastic/infra-monitoring-ui',
  '/src/dev/build/tasks/bundle_fleet_packages.ts @elastic/fleet @elastic/kibana-operations',
  '/src/apm.js @elastic/kibana-core @vigneshshanmugam',
  '/src/core/types/elasticsearch @elastic/apm-ui',
  '/packages/kbn-utility-types/src/dot_test.ts @dgieselaar',
  '/x-pack/test/alerting_api_integration/observability/synthetics_rule.ts @elastic/uptime',
  '/x-pack/test/alerting_api_integration/observability/index.ts @elastic/uptime',
  '/x-pack/plugins/apm/public/application/uxApp.tsx @elastic/uptime',
  '/x-pack/plugins/apm/public/components/app/rum_dashboard @elastic/uptime',
  '/x-pack/test/apm_api_integration/tests/csm/ @elastic/uptime',
  '/x-pack/test/api_integration_basic/apis/ml/ @elastic/ml-ui',
  '/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/ml_rule_types/ @elastic/ml-ui',
  '/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/transform_rule_types/ @elastic/ml-ui',
  '/x-pack/test/screenshot_creation/services/ml_screenshots.ts @elastic/ml-ui',
  '/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis',
  '/src/dev/license_checker/config.ts @elastic/kibana-operations',
  '/test/visual_regression @elastic/appex-qa',
  '/x-pack/test/visual_regression @elastic/appex-qa',
  '/src/core/public/i18n/  @elastic/kibana-localization @elastic/kibana-core',
  '/x-pack/plugins/security_solution/public/common/components/alerts_viewer @elastic/security-threat-hunting-investigations',
  '/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_action @elastic/security-threat-hunting-investigations',
  '/x-pack/plugins/security_solution/public/detections/components/alerts_info @elastic/security-threat-hunting-investigations',
  '/x-pack/plugins/security_solution/common/search_strategy/security_solution/user @elastic/security-threat-hunting-explore',
  '/x-pack/plugins/security_solution/cypress/upgrade_e2e/threat_hunting/cases @elastic/security-threat-hunting-explore',
  '/x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema @elastic/security-detection-rule-management @elastic/security-detection-engine',
  '/x-pack/plugins/security_solution/common/api/detection_engine/fleet_integrations @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/api/detection_engine/prebuilt_rules @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/api/detection_engine/rule_management @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/api/detection_engine/rule_monitoring @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/detection_engine/fleet_integrations @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/detection_engine/prebuilt_rules @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/detection_engine/rule_monitoring @elastic/security-detection-rule-management',
  '/x-pack/plugins/security_solution/common/detection_engine/rule_exceptions @elastic/security-detection-engine',
  '/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions_ui @elastic/security-detection-engine',
  '/x-pack/plugins/security_solution/public/common/components/exceptions @elastic/security-detection-engine',
  '/x-pack/plugins/security_solution/server/lib/sourcerer @elastic/security-detection-engine',
  '/x-pack/plugins/security_solution/cypress/e2e/detection_rules @elastic/security-detection-rule-management @elastic/security-detection-engine',
  '/x-pack/plugins/security_solution/cypress/plugins @elastic/security-detections-response @elastic/security-threat-hunting',
  '/x-pack/plugins/security_solution/common/ecs @elastic/security-threat-hunting-investigations',
  '/x-pack/plugins/security_solution/server/lib/detection_engine/rule_actions @elastic/security-detection-engine @elastic/security-detection-rule-management',
  'x-pack/plugins/security_solution/cypress/ccs_e2e @elastic/security-engineering-productivity',
  'x-pack/plugins/security_solution/cypress/upgrade_e2e @elastic/security-engineering-productivity',
  '/x-pack/plugins/security_solution/common/detection_engine/rule_response_actions @elastic/security-defend-workflows',
  '/x-pack/plugins/security_solution/public/common/components/guided_onboarding @elastic/security-threat-hunting-explore',
  '/x-pack/plugins/apm/**/*.scss @elastic/observability-design',
  '/x-pack/plugins/endpoint/**/*.scss @elastic/security-design',
  '/x-pack/plugins/security_solution_ess/**/*.scss @elastic/security-design',
  '/x-pack/plugins/security_solution_serverless/**/*.scss @elastic/security-design'
]
```
  • Loading branch information
@banderror
banderror authored Aug 16, 2023
1 parent 5b2859f commit a3e51bf
Showing 1 changed file with 20 additions and 24 deletions.
44 changes: 20 additions & 24 deletions .github/CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1157,15 +1157,12 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
/x-pack/plugins/stack_connectors/common/sentinelone @elastic/security-defend-workflows

## Security Solution sub teams - Detection Rule Management
/x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema @elastic/security-detection-rule-management @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/fleet_integrations @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/api/detection_engine/model/rule_schema @elastic/security-detection-rule-management @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/prebuilt_rules @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/api/detection_engine/rule_management @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/api/detection_engine/rule_monitoring @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/detection_engine/fleet_integrations @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/detection_engine/prebuilt_rules @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/detection_engine/rule_management @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/common/detection_engine/rule_monitoring @elastic/security-detection-rule-management

/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules @elastic/security-detection-rule-management
/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management @elastic/security-detection-rule-management
Expand Down Expand Up @@ -1196,24 +1193,37 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_management @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_schema @elastic/security-detection-rule-management @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/utils @elastic/security-detection-rule-management

/x-pack/plugins/security_solution/scripts/openapi @elastic/security-detection-rule-management

## Security Solution sub teams - Detection Engine

/x-pack/plugins/security_solution/common/api/detection_engine @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/alert_tags @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/index_management @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/model/alerts @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/rule_exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/rule_preview @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/signals @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/api/detection_engine/signals_migration @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/cti @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/field_maps @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/risk_engine @elastic/security-detection-engine

/x-pack/plugins/security_solution/public/common/components/sourcerer @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/detections/containers/detection_engine/lists @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/detections/pages/alerts @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/entity_analytics @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/exceptions @elastic/security-detection-engine

/x-pack/plugins/security_solution/server/lib/detection_engine/migrations @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_actions_legacy @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_preview @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_types @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/index @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/signals @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/sourcerer @elastic/security-detection-engine

/x-pack/test/security_solution_cypress/cypress/e2e/data_sources @elastic/security-detection-engine
/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation @elastic/security-detection-engine
Expand All @@ -1222,40 +1232,26 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
/x-pack/test/security_solution_cypress/cypress/e2e/exceptions @elastic/security-detection-engine
/x-pack/test/security_solution_cypress/cypress/e2e/overview @elastic/security-detection-engine

/x-pack/plugins/security_solution/common/detection_engine/rule_exceptions @elastic/security-detection-engine

/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions_ui @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/common/components/exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/detections/containers/detection_engine/lists @elastic/security-detection-engine
/x-pack/plugins/security_solution/public/common/components/sourcerer @elastic/security-detection-engine

/x-pack/plugins/security_solution/server/lib/detection_engine/rule_actions_legacy @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_exceptions @elastic/security-detection-engine
/x-pack/plugins/security_solution/server/lib/sourcerer @elastic/security-detection-engine

## Security Threat Intelligence - Under Security Platform
/x-pack/plugins/security_solution/public/common/components/threat_match @elastic/security-detection-engine

## Security Solution cross teams ownership
/x-pack/test/security_solution_cypress/cypress/fixtures @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/test/security_solution_cypress/cypress/helpers @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/test/security_solution_cypress/cypress/e2e/detection_rules @elastic/security-detection-rule-management @elastic/security-detection-engine
/x-pack/test/security_solution_cypress/cypress/objects @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/test/security_solution_cypress/cypress/plugins @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/test/security_solution_cypress/cypress/screens/common @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/test/security_solution_cypress/cypress/support @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/test/security_solution_cypress/cypress/urls @elastic/security-threat-hunting-investigations @elastic/security-detection-engine

/x-pack/plugins/security_solution/common/ecs @elastic/security-threat-hunting-investigations
/x-pack/plugins/security_solution/common/test @elastic/security-detection-rule-management @elastic/security-detection-engine
/x-pack/plugins/security_solution/common/test @elastic/security-detections-response @elastic/security-threat-hunting

/x-pack/plugins/security_solution/public/common/components/callouts @elastic/security-detections-response
/x-pack/plugins/security_solution/public/common/components/hover_actions @elastic/security-threat-hunting-explore @elastic/security-threat-hunting-investigations

/x-pack/plugins/security_solution/server/lib/detection_engine/rule_actions @elastic/security-detection-engine @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/server/routes @elastic/security-detections-response @elastic/security-threat-hunting
/x-pack/plugins/security_solution/server/utils @elastic/security-detections-response @elastic/security-threat-hunting

## Security Solution sub teams - security-defend-workflows
/x-pack/plugins/security_solution/public/management/ @elastic/security-defend-workflows
Expand Down Expand Up @@ -1298,7 +1294,7 @@ x-pack/plugins/security_solution/public/threat_intelligence @elastic/protections
x-pack/test/threat_intelligence_cypress @elastic/protections-experience

# Security Defend Workflows - OSQuery Ownership
/x-pack/plugins/security_solution/common/detection_engine/rule_response_actions @elastic/security-defend-workflows
/x-pack/plugins/security_solution/common/api/detection_engine/model/rule_response_actions @elastic/security-defend-workflows
/x-pack/plugins/security_solution/public/detection_engine/rule_response_actions @elastic/security-defend-workflows
/x-pack/plugins/security_solution/server/lib/detection_engine/rule_response_actions @elastic/security-defend-workflows

Expand Down

0 comments on commit a3e51bf

Please sign in to comment.