Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controls] remove unused controls callout strings #163657

Merged
merged 5 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
controlGroupSelector,
useControlGroupContainer,
} from '../embeddable/control_group_container';
import { ControlGroupStrings } from '../control_group_strings';
import { useChildEmbeddable } from '../../hooks/use_child_embeddable';
import { ControlError } from './control_error_component';

Expand Down Expand Up @@ -135,11 +134,7 @@ export const ControlFrame = ({
<EuiFormRow
data-test-subj="control-frame-title"
fullWidth
label={
usingTwoLineLayout
? title || ControlGroupStrings.emptyState.getTwoLineLoadingTitle()
: undefined
}
label={usingTwoLineLayout ? title || '...' : undefined}
>
{form}
</EuiFormRow>
Expand Down
23 changes: 0 additions & 23 deletions src/plugins/controls/public/control_group/control_group_strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,6 @@
import { i18n } from '@kbn/i18n';

export const ControlGroupStrings = {
emptyState: {
getBadge: () =>
i18n.translate('controls.controlGroup.emptyState.badgeText', {
defaultMessage: 'New',
}),
getCallToAction: () =>
i18n.translate('controls.controlGroup.emptyState.callToAction', {
defaultMessage:
'Filtering your data just got better with Controls, letting you display only the data you want to explore.',
}),
getAddControlButtonTitle: () =>
i18n.translate('controls.controlGroup.emptyState.addControlButtonTitle', {
defaultMessage: 'Add control',
}),
getTwoLineLoadingTitle: () =>
i18n.translate('controls.controlGroup.emptyState.twoLineLoadingTitle', {
defaultMessage: '...',
}),
getDismissButton: () =>
i18n.translate('controls.controlGroup.emptyState.dismissButton', {
defaultMessage: 'Dismiss',
}),
},
manageControl: {
getFlyoutCreateTitle: () =>
i18n.translate('controls.controlGroup.manageControl.createFlyoutTitle', {
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -409,11 +409,6 @@
"controls.optionsList.popover.invalidSelectionsSectionTitle": "{invalidSelectionCount, plural, one {Sélection ignorée} many {Sélections ignorées} other {Sélections ignorées}}",
"controls.optionsList.popover.suggestionsAriaLabel": "{optionCount, plural, one {option disponible} many {options disponibles} other {options disponibles}} pour {fieldName}",
"controls.rangeSlider.errors.fieldNotFound": "Impossible de localiser le champ : {fieldName}",
"controls.controlGroup.emptyState.addControlButtonTitle": "Ajouter un contrôle",
"controls.controlGroup.emptyState.badgeText": "Nouveauté",
"controls.controlGroup.emptyState.callToAction": "Le filtrage des données s'est amélioré grâce aux contrôles, qui vous permettent d'afficher uniquement les données que vous souhaitez explorer.",
"controls.controlGroup.emptyState.dismissButton": "Rejeter",
"controls.controlGroup.emptyState.twoLineLoadingTitle": "...",
"controls.controlGroup.floatingActions.clearTitle": "Effacer",
"controls.controlGroup.floatingActions.editTitle": "Modifier",
"controls.controlGroup.floatingActions.removeTitle": "Supprimer",
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -409,11 +409,6 @@
"controls.optionsList.popover.invalidSelectionsSectionTitle": "{invalidSelectionCount, plural, other {選択項目}}が無視されました",
"controls.optionsList.popover.suggestionsAriaLabel": "{fieldName}の{optionCount, plural, other {オプション}}があります",
"controls.rangeSlider.errors.fieldNotFound": "フィールドが見つかりませんでした:{fieldName}",
"controls.controlGroup.emptyState.addControlButtonTitle": "コントロールを追加",
"controls.controlGroup.emptyState.badgeText": "新規",
"controls.controlGroup.emptyState.callToAction": "データのフィルタリングはコントロールによって効果的になりました。探索するデータのみを表示できます。",
"controls.controlGroup.emptyState.dismissButton": "閉じる",
"controls.controlGroup.emptyState.twoLineLoadingTitle": "...",
"controls.controlGroup.floatingActions.clearTitle": "クリア",
"controls.controlGroup.floatingActions.editTitle": "編集",
"controls.controlGroup.floatingActions.removeTitle": "削除",
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -409,11 +409,6 @@
"controls.optionsList.popover.invalidSelectionsSectionTitle": "已忽略{invalidSelectionCount, plural, other {选择的内容}}",
"controls.optionsList.popover.suggestionsAriaLabel": "{fieldName} 的可用{optionCount, plural, other {选项}}",
"controls.rangeSlider.errors.fieldNotFound": "找不到字段:{fieldName}",
"controls.controlGroup.emptyState.addControlButtonTitle": "添加控件",
"controls.controlGroup.emptyState.badgeText": "新建",
"controls.controlGroup.emptyState.callToAction": "使用控件可以更有效地筛选数据,允许您仅显示要浏览的数据。",
"controls.controlGroup.emptyState.dismissButton": "关闭",
"controls.controlGroup.emptyState.twoLineLoadingTitle": "...",
"controls.controlGroup.floatingActions.clearTitle": "清除",
"controls.controlGroup.floatingActions.editTitle": "编辑",
"controls.controlGroup.floatingActions.removeTitle": "删除",
Expand Down