Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controls] remove unused controls callout strings #163657

Merged
merged 5 commits into from
Aug 14, 2023
Merged

[controls] remove unused controls callout strings #163657

merged 5 commits into from
Aug 14, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 10, 2023

Closes #163461

#147897 removed controls callout

This PR cleans up some strings that where missed.

@nreese nreese marked this pull request as ready for review August 10, 2023 22:41
@nreese nreese requested a review from a team as a code owner August 10, 2023 22:41
@nreese nreese added Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Aug 14, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / Machine Learning annotations get_annotations "before all" hook for "should fetch all annotations for jobId"
  • [job] [logs] Security Solution Cypress Tests #3 / timeline data providers persists timeline when data provider is updated by dragging a field from data grid persists timeline when data provider is updated by dragging a field from data grid

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 199.3KB 197.2KB -2.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit d5055ac into elastic:main Aug 14, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 14, 2023
bryce-b pushed a commit that referenced this pull request Aug 17, 2023
@nreese @kibanamachine @bryce-b
[controls] remove unused controls callout strings (#163657)
dd20700 
Closes #163461

#147897 removed controls callout

This PR cleans up some strings that where missed.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Input Control Input controls visualization release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Controls] Remove "New" banner
5 participants
@nreese @elasticmachine @kibana-ci @ThomThomson @kibanamachine