Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Serverless] Manage/restrict endpoint exceptions on serverless via PLI definitions #163613

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Aug 10, 2023

Summary

WIP
blocked by /pull/163759

Adds kibana sub-features to manage endpoint exceptions for alerts and rules.

Checklist

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ashokaditya ashokaditya added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint labels Aug 10, 2023
@ashokaditya ashokaditya self-assigned this Aug 10, 2023
@ashokaditya ashokaditya force-pushed the tas/dw-endpoint-exceptions-pli-serverless-ess-7223 branch from 586b63c to 0facaf1 Compare August 10, 2023 14:44
@ashokaditya ashokaditya force-pushed the tas/dw-endpoint-exceptions-pli-serverless-ess-7223 branch from 0facaf1 to 0998861 Compare August 10, 2023 16:05
Based on serverless `endpoint` PLIs for serverless limit visibility of endpoint exception list on rules page shared lists.

refs elastic/security-team/issues/7223
@ashokaditya ashokaditya force-pushed the tas/dw-endpoint-exceptions-pli-serverless-ess-7223 branch from 38aea0f to 12dd2c1 Compare August 11, 2023 09:38
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 15, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it disables for event.kind: alert and agent.type: endpoint
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it disables for event.kind: undefined and agent.type: endpoint
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it disables for eventType=raw
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it does not render the analyze event button when the event is from an unsupported source
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it enables for event.kind: event and agent.type: endpoint
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it enables for eventType=signal
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it should not show session view button on action tabs for basic users
  • [job] [logs] Jest Tests #19 / Actions Alert context menu enabled? it shows the analyze event button when the event is from an endpoint
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step if all conditions make isTourAnchor=true, SecurityTourStep is active
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step if isTourAnchor=false, SecurityTourStep is not active
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step if isTourShown is false [isTourAnchor=false], SecurityTourStep is not active
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step on expand event click and SecurityTourStep is active, but step is not 2, do not incrementStep
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step on expand event click and SecurityTourStep is active, incrementStep
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step on expand event click and SecurityTourStep is not active, do not incrementStep
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step tour condition true: ariaRowindex Single condition does not make tour step exist
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step tour condition true: ecsData Single condition does not make tour step exist
  • [job] [logs] Jest Tests #19 / Actions Guided Onboarding Step tour condition true: timelineId Single condition does not make tour step exist
  • [job] [logs] Jest Tests #19 / Actions it does NOT render a checkbox for selecting the event when showCheckboxes is false
  • [job] [logs] Jest Tests #19 / Actions it does NOT render a checkbox for selecting the event when tGridEnabled is true
  • [job] [logs] Jest Tests #19 / Actions it renders a checkbox for selecting the event when showCheckboxes is true
  • [job] [logs] Security Solution Cypress Tests #6 / Endpoint Exceptions workflows from Alert Should be able to create and close single Endpoint exception from overflow menu Should be able to create and close single Endpoint exception from overflow menu
  • [job] [logs] Security Solution Cypress Tests #6 / Endpoint Exceptions workflows from Alert Should be able to create and close single Endpoint exception from overflow menu Should be able to create and close single Endpoint exception from overflow menu
  • [job] [logs] Security Solution Cypress Tests #6 / Endpoint Exceptions workflows from Alert Should be able to create Endpoint exception from Alerts take action button, and change multiple exception items without resetting to initial auto-prefilled entries Should be able to create Endpoint exception from Alerts take action button, and change multiple exception items without resetting to initial auto-prefilled entries
  • [job] [logs] Security Solution Cypress Tests #6 / Endpoint Exceptions workflows from Alert Should be able to create Endpoint exception from Alerts take action button, and change multiple exception items without resetting to initial auto-prefilled entries Should be able to create Endpoint exception from Alerts take action button, and change multiple exception items without resetting to initial auto-prefilled entries
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #3 / Endpoint generated alerts "before all" hook for "should create a Detection Engine alert from an endpoint alert" "before all" hook for "should create a Detection Engine alert from an endpoint alert"
  • [job] [logs] FTR Configs #8 / endpoint Response Actions Responder from timeline should show Responder from alert in a timeline
  • [job] [logs] Jest Tests #2 / event details footer component it renders the take action dropdown
  • [job] [logs] Jest Tests #2 / EventColumnView it does NOT render a notes button when isEventsViewer is true
  • [job] [logs] Jest Tests #2 / EventColumnView it does NOT render a pin button when isEventViewer is true
  • [job] [logs] Jest Tests #2 / EventColumnView it invokes toggleShowNotes when the button for adding notes is clicked
  • [job] [logs] Jest Tests #2 / EventColumnView it renders a custom control column in addition to the default control column
  • [job] [logs] Jest Tests #2 / EventColumnView it renders correct tooltip for NotesButton - timeline
  • [job] [logs] Jest Tests #2 / EventColumnView it renders correct tooltip for NotesButton - timeline template
  • [job] [logs] Security Solution Cypress Tests #3 / Manage lists from "Shared Exception Lists" page Create/Export/Delete List Export exception list Export exception list
  • [job] [logs] Security Solution Cypress Tests #3 / Manage lists from "Shared Exception Lists" page Create/Export/Delete List Export exception list Export exception list
  • [job] [logs] Defend Workflows Cypress Tests #1 / When defining a kibana role for Endpoint security access should display RBAC entries with expected controls should display RBAC entries with expected controls
  • [job] [logs] Defend Workflows Cypress Tests #1 / When defining a kibana role for Endpoint security access should display RBAC entries with expected controls should display RBAC entries with expected controls

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.6MB 15.6MB +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 62.2KB 62.3KB +43.0B
securitySolutionServerless 37.9KB 38.0KB +70.0B
total +113.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya
Copy link
Member Author

closed in favour of /pull/164107

@ashokaditya ashokaditya deleted the tas/dw-endpoint-exceptions-pli-serverless-ess-7223 branch August 16, 2023 18:06
@ashokaditya ashokaditya changed the title [Security Solution][Serverless] Manage/restrict endpoint exceptions on serverless vis PLI definitions [Security Solution][Serverless] Manage/restrict endpoint exceptions on serverless via PLI definitions Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OLM Sprint release_note:enhancement Team:Defend Workflows “EDR Workflows” sub-team of Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants