-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Discovery] Run API integration tests in Serverless #163550
[Data Discovery] Run API integration tests in Serverless #163550
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
7669f29
to
2c9e15d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @davismcphee , I thought you would print this code and send it to me? Neithertheless, looks good to me, so much LOC++
Cheers,
Melon 🍈
PS a follow up issue to track the deduplication like suggested in the other PR sounds like a good idea, although I might complain about the reduced net worth of our code base then
36a6bf2
to
b09cf11
Compare
It's on its way in the mail, long way from Canada to Austria! 😄 And definitely, will add a followup issue for deduping tests 👍 |
f20f7b7
to
fc35cc8
Compare
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: cc @davismcphee |
Summary
This PR copies the Data Discovery API integration tests to
test_serverless
. They are currently in the common folder and will run once for each project type in CI, but we could instead move them to a specific project if we don't want to run them three times each.In the future these should run as deployment-agnostic tests, but support does not yet exist (see #161574), so in the meantime they've been duplicated and modified in place. I've left
TODO
comments where test files have been modified so we know what needs to be addressed once they are converted to deployment-agnostic tests.Part of #162347.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibilityFor maintainers