Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Discovery] Run API integration tests in Serverless #163550

Merged
merged 13 commits into from
Aug 29, 2023

Conversation

davismcphee
Copy link
Contributor

Summary

This PR copies the Data Discovery API integration tests to test_serverless. They are currently in the common folder and will run once for each project type in CI, but we could instead move them to a specific project if we don't want to run them three times each.

In the future these should run as deployment-agnostic tests, but support does not yet exist (see #161574), so in the meantime they've been duplicated and modified in place. I've left TODO comments where test files have been modified so we know what needs to be addressed once they are converted to deployment-agnostic tests.

Part of #162347.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Aug 10, 2023
@davismcphee davismcphee self-assigned this Aug 10, 2023
@davismcphee davismcphee marked this pull request as ready for review August 10, 2023 02:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee requested a review from a team August 10, 2023 02:48
@davismcphee davismcphee force-pushed the serverless-api-integration-tests branch from 7669f29 to 2c9e15d Compare August 21, 2023 22:43
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @davismcphee , I thought you would print this code and send it to me? Neithertheless, looks good to me, so much LOC++
Cheers,
Melon 🍈
PS a follow up issue to track the deduplication like suggested in the other PR sounds like a good idea, although I might complain about the reduced net worth of our code base then

@davismcphee davismcphee force-pushed the serverless-api-integration-tests branch from 36a6bf2 to b09cf11 Compare August 25, 2023 20:03
@davismcphee
Copy link
Contributor Author

Dear @davismcphee , I thought you would print this code and send it to me? Neithertheless, looks good to me, so much LOC++ Cheers, Melon 🍈 PS a follow up issue to track the deduplication like suggested in the other PR sounds like a good idea, although I might complain about the reduced net worth of our code base then

It's on its way in the mail, long way from Canada to Austria! 😄 And definitely, will add a followup issue for deduping tests 👍

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 29, 2023

💚 Build Succeeded

  • Buildkite Build
  • Commit: d2db8f9
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-163550-d2db8f900022

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5580 +5580
total size - 6.0MB +6.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit c288c8b into elastic:main Aug 29, 2023
@davismcphee davismcphee deleted the serverless-api-integration-tests branch August 29, 2023 13:22
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-serverless-image release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants