Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign functional tests and example plugins code ownership to Data Discovery #162740

Merged
merged 14 commits into from
Aug 4, 2023
Merged

Assign functional tests and example plugins code ownership to Data Discovery #162740

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e7c9f0a
Update CODEOWNERS file to assign data discovery to all relevant test …
davismcphee Jul 28, 2023
0fd178b
Assign example plugins to data discovery
davismcphee Jul 28, 2023
4e838b2
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 28, 2023
4fafdff
Fix bfetch code ownership
davismcphee Jul 28, 2023
826010c
Add newline to examples/bfetch_explorer/kibana.jsonc
davismcphee Jul 28, 2023
dca7c0a
Fix test/functional/apps/management/data_views imports
davismcphee Jul 28, 2023
b5a0e0c
Remove /test/accessibility/apps/management.ts from Data Discovery in …
davismcphee Jul 31, 2023
536402d
Merge branch 'main' into codeowners-testing-changes
davismcphee Jul 31, 2023
88b2110
Remove test/api_integration/apis/unified_field_list from CODEOWNERS
davismcphee Jul 31, 2023
e3ae1bf
Merge branch 'main' into codeowners-testing-changes
davismcphee Aug 1, 2023
e8657e9
Merge branch 'main' into codeowners-testing-changes
davismcphee Aug 1, 2023
17c6329
Merge branch 'main' into codeowners-testing-changes
davismcphee Aug 1, 2023
b46ab4e
More updates to Data Discovery code ownership
davismcphee Aug 2, 2023
989bbdc
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -782,15 +782,38 @@ packages/kbn-yarn-lock-validator @elastic/kibana-operations
# used for the 'team' designator within Kibana Stats

# Data Discovery
/x-pack/test/functional/apps/discover/ @elastic/kibana-data-discovery
/x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/discover/ @elastic/kibana-data-discovery
/test/functional/apps/discover/ @elastic/kibana-data-discovery
/test/functional/apps/context/ @elastic/kibana-data-discovery
/test/api_integration/apis/unified_field_list/ @elastic/kibana-data-discovery
/x-pack/test/search_sessions_integration/ @elastic/kibana-data-discovery
/test/plugin_functional/test_suites/data_plugin @elastic/kibana-data-discovery
/examples/demo_search/ @elastic/kibana-data-discovery
/examples/demo_search @elastic/kibana-data-discovery
davismcphee marked this conversation as resolved.
Show resolved Hide resolved
/test/accessibility/apps/discover.ts @elastic/kibana-data-discovery
/test/accessibility/apps/management.ts @elastic/kibana-data-discovery
davismcphee marked this conversation as resolved.
Show resolved Hide resolved
/test/api_integration/apis/data_views @elastic/kibana-data-discovery
/test/api_integration/apis/data_view_field_editor @elastic/kibana-data-discovery
/test/api_integration/apis/kql_telemetry @elastic/kibana-data-discovery
/test/api_integration/apis/scripts @elastic/kibana-data-discovery
/test/api_integration/apis/search @elastic/kibana-data-discovery
/test/api_integration/apis/unified_field_list @elastic/kibana-data-discovery
/test/examples/bfetch_explorer @elastic/kibana-data-discovery
/test/examples/data_view_field_editor_example @elastic/kibana-data-discovery
/test/examples/discover_customization_examples @elastic/kibana-data-discovery
/test/examples/field_formats @elastic/kibana-data-discovery
/test/examples/partial_results @elastic/kibana-data-discovery
/test/examples/search @elastic/kibana-data-discovery
/test/examples/unified_field_list_examples @elastic/kibana-data-discovery
/test/functional/apps/context @elastic/kibana-data-discovery
/test/functional/apps/discover @elastic/kibana-data-discovery
/test/functional/apps/management/ccs_compatibility/_data_views_ccs.ts @elastic/kibana-data-discovery
/test/functional/apps/management/data_views @elastic/kibana-data-discovery
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved all the data views tests from /test/functional/apps/management to /test/functional/apps/management/data_views to easily assign all of them to us.

/test/plugin_functional/test_suites/data_plugin @elastic/kibana-data-discovery
davismcphee marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/accessibility/apps/search_sessions.ts @elastic/kibana-data-discovery
/x-pack/test/api_integration/apis/management/rollup @elastic/kibana-data-discovery
davismcphee marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/api_integration/apis/search @elastic/kibana-data-discovery
/x-pack/test/examples/search_examples @elastic/kibana-data-discovery
/x-pack/test/functional/apps/data_views @elastic/kibana-data-discovery
/x-pack/test/functional/apps/discover @elastic/kibana-data-discovery
/x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/discover @elastic/kibana-data-discovery
/x-pack/test/search_sessions_integration @elastic/kibana-data-discovery
/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js @elastic/kibana-data-discovery
/x-pack/test/stack_functional_integration/apps/management/_index_pattern_create.js @elastic/kibana-data-discovery
/x-pack/test/upgrade/apps/discover @elastic/kibana-data-discovery

# Vis Editors
/src/plugins/visualize/ @elastic/kibana-visualizations
Expand Down
11 changes: 3 additions & 8 deletions examples/bfetch_explorer/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
{
"type": "plugin",
"id": "@kbn/bfetch-explorer-plugin",
"owner": "@elastic/appex-sharedux",
"owner": "@elastic/kibana-data-discovery",
"plugin": {
"id": "bfetchExplorer",
"server": true,
"browser": true,
"requiredPlugins": [
"bfetch",
"developerExamples"
],
"requiredBundles": [
"kibanaReact"
]
"requiredPlugins": ["bfetch", "developerExamples"],
"requiredBundles": ["kibanaReact"]
}
}
8 changes: 2 additions & 6 deletions examples/data_view_field_editor_example/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
{
"type": "plugin",
"id": "@kbn/data-view-field-editor-example-plugin",
"owner": "@elastic/kibana-app-services",
"owner": "@elastic/kibana-data-discovery",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was still assigned to app services, but I'm assuming it should be us now.

"description": "Data view field editor example app",
"plugin": {
"id": "dataViewFieldEditorExample",
"server": false,
"browser": true,
"requiredPlugins": [
"data",
"dataViewFieldEditor",
"developerExamples"
]
"requiredPlugins": ["data", "dataViewFieldEditor", "developerExamples"]
}
}
2 changes: 1 addition & 1 deletion ...anagement/_create_index_pattern_wizard.ts → ...ata_views/_create_index_pattern_wizard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
Expand Down
2 changes: 1 addition & 1 deletion ...ps/management/_data_view_create_delete.ts → ...nt/data_views/_data_view_create_delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
Expand Down
2 changes: 1 addition & 1 deletion ...ps/management/_data_view_relationships.ts → ...nt/data_views/_data_view_relationships.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
Expand Down
0 ...functional/apps/management/_edit_field.ts → ...apps/management/data_views/_edit_field.ts
View file
Open in desktop
File renamed without changes.
0 ...apps/management/_exclude_index_pattern.ts → ...ment/data_views/_exclude_index_pattern.ts
View file
Open in desktop
File renamed without changes.
0 ...ional/apps/management/_field_formatter.ts → ...management/data_views/_field_formatter.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...nctional/apps/management/_handle_alias.ts → ...ps/management/data_views/_handle_alias.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
Expand Down
0 ...onal/apps/management/_handle_not_found.ts → ...anagement/data_views/_handle_not_found.ts
View file
Open in desktop
File renamed without changes.
0 ...ps/management/_handle_version_conflict.ts → ...nt/data_views/_handle_version_conflict.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../apps/management/_index_pattern_filter.ts → ...ement/data_views/_index_pattern_filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
Expand Down
0 ...s/management/_index_pattern_popularity.ts → ...t/data_views/_index_pattern_popularity.ts
View file
Open in desktop
File renamed without changes.
0 ...management/_index_pattern_results_sort.ts → ...data_views/_index_pattern_results_sort.ts
View file
Open in desktop
File renamed without changes.
0 .../apps/management/_index_patterns_empty.ts → ...ement/data_views/_index_patterns_empty.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...l/apps/management/_legacy_url_redirect.ts → ...gement/data_views/_legacy_url_redirect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getPageObjects, getService }: FtrProviderContext) {
const browser = getService('browser');
Expand Down
0 ...tional/apps/management/_runtime_fields.ts → .../management/data_views/_runtime_fields.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...s/management/_runtime_fields_composite.ts → ...t/data_views/_runtime_fields_composite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
Expand Down
0 ...ional/apps/management/_scripted_fields.ts → ...management/data_views/_scripted_fields.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...agement/_scripted_fields_classic_table.ts → ...a_views/_scripted_fields_classic_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// it will automatically insert a a closing square brace ], etc.

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
Expand Down
0 ...pps/management/_scripted_fields_filter.ts → ...ent/data_views/_scripted_fields_filter.ts
View file
Open in desktop
File renamed without changes.
0 ...ps/management/_scripted_fields_preview.ts → ...nt/data_views/_scripted_fields_preview.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...onal/apps/management/_test_huge_fields.ts → ...anagement/data_views/_test_huge_fields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
Expand Down