Assign functional tests and example plugins code ownership to Data Discovery #162740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
added
release_note:skip
davismcphee
commented
Jul 28, 2023
| /test/functional/apps/context @elastic/kibana-data-discovery | ||
| /test/functional/apps/discover @elastic/kibana-data-discovery | ||
| /test/functional/apps/management/ccs_compatibility/_data_views_ccs.ts @elastic/kibana-data-discovery | ||
| /test/functional/apps/management/data_views @elastic/kibana-data-discovery |
There was a problem hiding this comment.
I moved all the data views tests from /test/functional/apps/management to /test/functional/apps/management/data_views to easily assign all of them to us.
| @@ -1,16 +1,12 @@ | |||
| { | |||
| "type": "plugin", | |||
| "id": "@kbn/data-view-field-editor-example-plugin", | |||
| "owner": "@elastic/kibana-app-services", | |||
| "owner": "@elastic/kibana-data-discovery", | |||
There was a problem hiding this comment.
Looks like this was still assigned to app services, but I'm assuming it should be us now.
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
approved these changes
Aug 1, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @davismcphee |
kertal
approved these changes
Aug 3, 2023
kibanamachine
added
v8.10.0
backport:skip
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
…scovery (elastic#162740) ## Summary This PR assigns code ownership to the Data Discovery team for various functional tests as well as a couple of example plugins. All of the tests assigned to us in `CODEOWNERS` currently have no one else assigned to them. ### Checklist - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ - [ ] ~Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR assigns code ownership to the Data Discovery team for various functional tests as well as a couple of example plugins. All of the tests assigned to us in
CODEOWNERScurrently have no one else assigned to them.Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibilityFor maintainers