-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slo): introduce new search capabilities #162665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
release_note:skip
Skip the PR/issue when compiling release notes
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.10.0
labels
Jul 27, 2023
kdelemme
changed the title
Slo/feature branch
feat(slo): introduce new search capabilities
Jul 27, 2023
kdelemme
added
release_note:feature
Makes this part of the condensed release notes
release_note:breaking
and removed
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jul 28, 2023
kdelemme
force-pushed
the
slo/feature-branch
branch
2 times, most recently
from
July 28, 2023 13:37
6662da9
to
533a6f2
Compare
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
Resolves elastic#161393 ## Summary This PR is the first of a series to implement the summary and search improvement feature on SLO. Every PR will be merged against the feature branch: `slo/feature-branch`. And we'll update this feature branch with main as often as possible to keep conflict as a minimum. This PR changes the SLO rollup index mapping, adding more fields to it, that we are going to use to summarize the SLO rollup data later. It also includes the SLO summary index templates (mappings, settings, template) and install them with the other templates. Since this is a **breaking change**, any SLO running will be shown as `NO_DATA`. You can remove the SLO through the API or the UI, or update them (make sure you change something significant (time window, indicator params, ...) in order to induce a revision bump) so the underlying transform is recreated using the new index structure.
kdelemme
force-pushed
the
slo/feature-branch
branch
from
July 28, 2023 17:22
533a6f2
to
6f0443f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
simianhacker
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
gsoldevila
added a commit
that referenced
this pull request
Sep 14, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2023
Revert elastic#162665 (cherry picked from commit 33108a1)
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [Remove excessively verbose logs (#166525)](#166525) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-14T21:41:10Z","message":"Remove excessively verbose logs (#166525)\n\nRevert #162665","sha":"33108a1638d2f153883cfbf6c6127ba7fb051077","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-minor","v8.11.0","v8.10.1"],"number":166525,"url":"https://github.com/elastic/kibana/pull/166525","mergeCommit":{"message":"Remove excessively verbose logs (#166525)\n\nRevert #162665","sha":"33108a1638d2f153883cfbf6c6127ba7fb051077"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166525","number":166525,"mergeCommit":{"message":"Remove excessively verbose logs (#166525)\n\nRevert #162665","sha":"33108a1638d2f153883cfbf6c6127ba7fb051077"}},{"branch":"8.10","label":"v8.10.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:breaking
release_note:feature
Makes this part of the condensed release notes
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges the new summary search capabilities into main.
This PR introduces breaking changes in various places, and we have decided to not handle backward compatibility:
If some SLOs have been installed in a prior version at 8.10, the user will need to remove them manually from the UI, or by deleting the Saved Object and the associated Transform.
In a nutshell, we have added another layer of transforms to summarize each SLO so we can use this data in the find API and therefore in the listing page. Because of the inherent delay of the transform, the summary data is not available right after creating or updating an SLO. To mitigate this, we index a temporary summary document with "no_data values for the given SLO, and when we search the summary documents, we dedupe the temporary vs non temporary summary documents, and delete them in the brackground. Therefore the summary documents are eventually consistent as we read through them.
Release note
SLO definition and computed values are now summarized periodically into a summary search index, allowing users to search by name, tags, SLO budgeting type or time window, and even by and sort by error budget consumed, error budget remaining, SLI value or status. This is a breaking change due to the changes in the transform definitions. To mitigate this change, you will need to re-create your SLOs by exporting the definitions via the listing API.