Improve time window handling and validation #161978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
force-pushed
the
slo/feature-branch_time-window-refactoring
branch
from
e05f730 to
b7d0fdd
Compare
kdelemme
force-pushed
the
slo/feature-branch_time-window-refactoring
branch
from
b7d0fdd to
cfb087b
Compare
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
| case 'w': | ||
| return 'weeks'; | ||
| return 'isoWeek'; |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kdelemme |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jul 17, 2023
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jul 18, 2023
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jul 24, 2023
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jul 27, 2023
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enforces the following time window for SLOs:
We enforce these durations so we can use a finite number of summary transforms.
I've also fixed an issue with calendar aligned time window when calculating the date range for a weekly one: relying on
startOf('isoWeek')which is Monday, as for Elasticsearch.I've cleaned up a bunch of unnecessary tests related to no more valid time window duration as well.