Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove EuiPageTemplate from failure prompt #162552

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[APM] Remove EuiPageTemplate from failure prompt #162552

merged 1 commit into from
Aug 7, 2023

Conversation

gbamparop
Copy link
Contributor

Removes EuiPageTemplate_Deprecated from the failure prompt in infra tab which is displayed if the fetch request for the infra attributes fails.

Before

image

After

image

No data screen

image

Closes #161415

@gbamparop gbamparop requested a review from a team as a code owner July 26, 2023 10:51
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 26, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop gbamparop added the release_note:skip Skip the PR/issue when compiling release notes label Jul 26, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB -113.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gbamparop gbamparop merged commit 3a9deee into elastic:main Aug 7, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 7, 2023
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
@gbamparop @bryce-b
[APM] Remove EuiPageTemplate from failure prompt (elastic#162552)
485ccc4 
Removes `EuiPageTemplate_Deprecated` from the failure prompt in infra
tab which is displayed if the fetch request for the infra attributes
fails.

### Before
<img width="1508" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/b1a51640-8c65-4f55-bfa2-6878357cd6ba">

### After
<img width="1521" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/b502b68e-28ca-44b8-a293-4173ae4eadbb">

### No data screen
<img width="1523" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/510102a2-89d9-4114-b5f7-92c2e536be31">

Closes elastic#161415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Migrate all usages of EuiPage*_Deprecated
5 participants
@gbamparop @apmmachine @kibana-ci @dgieselaar @kibanamachine