Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Migrate all usages of EuiPage*_Deprecated #161415

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #162552
Closed
Tracked by #161872

[APM] Migrate all usages of EuiPage*_Deprecated #161415

cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #162552
Assignees
@gbamparop
Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan deprecation_warnings EUI Team:APM All issues that need APM UI Team support

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jul 7, 2023 •
edited
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have 1 usage of EuiPage*_Deprecated components, which you can find listed here:

https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Fapm%2F&type=code

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added Team:APM All issues that need APM UI Team support deprecation_warnings EUI labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@gbamparop gbamparop mentioned this issue Jul 26, 2023
Merged
@gbamparop gbamparop self-assigned this Jul 26, 2023
gbamparop added a commit that referenced this issue Aug 7, 2023
@gbamparop
[APM] Remove EuiPageTemplate from failure prompt (#162552)
3a9deee 
Removes `EuiPageTemplate_Deprecated` from the failure prompt in infra
tab which is displayed if the fetch request for the infra attributes
fails.

### Before
<img width="1508" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/b1a51640-8c65-4f55-bfa2-6878357cd6ba">

### After
<img width="1521" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/b502b68e-28ca-44b8-a293-4173ae4eadbb">

### No data screen
<img width="1523" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/510102a2-89d9-4114-b5f7-92c2e536be31">

Closes #161415
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@gbamparop @bryce-b
[APM] Remove EuiPageTemplate from failure prompt (elastic#162552)
485ccc4 
Removes `EuiPageTemplate_Deprecated` from the failure prompt in infra
tab which is displayed if the fetch request for the infra attributes
fails.

### Before
<img width="1508" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/b1a51640-8c65-4f55-bfa2-6878357cd6ba">

### After
<img width="1521" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/b502b68e-28ca-44b8-a293-4173ae4eadbb">

### No data screen
<img width="1523" alt="image"
src="https://github.com/elastic/kibana/assets/5831975/510102a2-89d9-4114-b5f7-92c2e536be31">

Closes elastic#161415
@gbamparop
Copy link
Contributor

Tested locally:

image

@gbamparop gbamparop added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbamparop gbamparop

Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan deprecation_warnings EUI Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Remove EuiPageTemplate from failure prompt gbamparop/kibana
3 participants
@cee-chen @gbamparop @elasticmachine