Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] Fix style of options list button #161473

Closed

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jul 7, 2023

Closes #161464

Summary

This PR fixes the styling of the options list control:

Before After
image image

Checklist

For maintainers

@Heenawter Heenawter added Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Controls labels Jul 7, 2023
@Heenawter Heenawter self-assigned this Jul 7, 2023
@Heenawter Heenawter marked this pull request as ready for review July 7, 2023 15:51
@Heenawter Heenawter requested a review from a team as a code owner July 7, 2023 15:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code only review. Do we know why this css wasn't needed before?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / Entity Analytics Dashboard With anomalies data enables a job
  • [job] [logs] Explore - Security Solution Tests #2 / risk tab should be able to change items count per page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 199.8KB 199.9KB +120.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@andreadelrio
Copy link
Contributor

andreadelrio commented Jul 7, 2023

LGTM! Code only review. Do we know why this css wasn't needed before?

The EUI team is currently investigating this. Seems like it has to do with an underlying component (EuiButtonEmpty) being converted to Emotion and EuiFilterButton not having been converted yet. They'll be working on a fix. Tagging them so they can provide a timeline @elastic/eui-team

@1Copenut
Copy link
Contributor

1Copenut commented Jul 7, 2023

EUI findings

Cee Chen and I took a look. Root cause theory is the order of Sass vs. Emotion css coming in, causing a style override. We are opting to move EuiFilterButton into Emotion and fold that into Kibana. I've got this on deck for Monday's grooming session. elastic/eui#6920

EUI CSS stacking order

Screen Shot 2023-07-07 at 12 52 38 PM

Kibana CSS stacking order

Screen Shot 2023-07-07 at 12 24 15 PM

@Heenawter Heenawter closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Controls] Options List border radius misaligned
6 participants