-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Controls] Fix style of options list button #161473
[Controls] Fix style of options list button #161473
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Code only review. Do we know why this css wasn't needed before?
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @Heenawter |
The EUI team is currently investigating this. Seems like it has to do with an underlying component (EuiButtonEmpty) being converted to Emotion and EuiFilterButton not having been converted yet. They'll be working on a fix. Tagging them so they can provide a timeline @elastic/eui-team |
EUI findingsCee Chen and I took a look. Root cause theory is the order of Sass vs. Emotion css coming in, causing a style override. We are opting to move EUI CSS stacking orderKibana CSS stacking order |
Closes #161464
Summary
This PR fixes the styling of the options list control:
Checklist
For maintainers