Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFilterButton] Sass and Emotion CSS order is causing an incorrect border-radius in Kibana components #6920

Closed
1Copenut opened this issue Jul 7, 2023 · 1 comment

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Jul 7, 2023

Describe the bug
@andreadelrio let us know there were at least two Kibana components that had a border / border-radius displaying incorrectly for buttons that were embedded with inputs. The EUI team's investigation concluded this is a difference in the order Emotion and Sass styles are loaded in EUI vs. Kibana.

The EUI team concluded the best way to manage this will be to convert EuiFilterButton to use Emotion and fold it into a next release. The fix would then be upstreamed into Kibana on next upgrade.

Environment and versions

  • EUI version: 83.0.0
  • React version: 17
  • Kibana version (if applicable): 8.8.2
  • Browser: Chrome
  • Operating System: MacOS

To Reproduce
Steps to reproduce the behavior:

  1. Pull latest main from Kibana and bootstrap it
  2. Load the sample flight data
  3. Navigate to the Discover view
  4. Observe the slight rounded border as shown in the screen shot below.

Expected behavior
The border should be square (not radiused) and not show through the background.

Screenshots
Frame 497

@cee-chen
Copy link
Contributor

cee-chen commented Jan 3, 2024

This was fixed by elastic/kibana#161592

@cee-chen cee-chen closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants