[7.17][Ops] Sync babel-related versions with main #161278
Conversation
delanni
force-pushed
the
sync-babel-version-with-main
branch
from
4ee15dd to
f7ba584
Compare
delanni
force-pushed
the
sync-babel-version-with-main
branch
from
66cbd27 to
344ad5c
Compare
delanni
added
chore
Team:Operations
delanni
changed the title
delanni
changed the title
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
| "@babel/cli": "^7.21.0", | ||
| "@babel/core": "^7.21.0", | ||
| "@babel/eslint-parser": "^7.19.1", | ||
| "@babel/eslint-plugin": "^7.19.1", | ||
| "@babel/generator": "^7.21.1", | ||
| "@babel/parser": "^7.21.2", | ||
| "@babel/plugin-proposal-class-properties": "^7.18.6", | ||
| "@babel/plugin-proposal-export-namespace-from": "^7.18.9", | ||
| "@babel/plugin-proposal-nullish-coalescing-operator": "^7.18.6", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.20.7", | ||
| "@babel/plugin-proposal-optional-chaining": "^7.21.0", | ||
| "@babel/plugin-proposal-private-methods": "^7.18.6", | ||
| "@babel/plugin-transform-runtime": "^7.21.0", | ||
| "@babel/preset-env": "^7.20.2", | ||
| "@babel/preset-react": "^7.18.6", | ||
| "@babel/preset-typescript": "^7.21.0", | ||
| "@babel/register": "^7.21.0", | ||
| "@babel/traverse": "^7.21.2", | ||
| "@babel/types": "^7.21.2", |
There was a problem hiding this comment.
Should these versions match @babel/core? Its the same on main so maybe we address it there first and backport?
There was a problem hiding this comment.
Maybe you're right - I wonder why it is not in sync on master - @mistic do you have any opinions on syncing the @babel/* versions to that of the core?
What I also wonder, the specifiers with ^ should be able to move around within the same major version, in theory they could resolve all to the same version.
There was a problem hiding this comment.
Thats a good point. I think we can move on with this PR as it is and then open a fix on main to this mismatch with babel/core that we can then backport to the other branches.
Regarding the second question and after thinking a little about this, I think whats is more important is to keep at least what we define in the package.json in sync across the branches, having that said we can keep the ^ and afford to have little differences in the yarn.lock because if we upgrade those things at the same time they will tend to be exact the same in every branch without us to have to be completely strict in the package.json.
Let me know what you think about it 😃
There was a problem hiding this comment.
👍 I believe the versions aren't always in sync (e.g. core is 7.22.8 and register is 7.22.5 currently), no-op releases are skipped but future releases will skip numbers to align, if anyone's curious as to why.
Summary
Synchronize Babel versions with
main(targeting ~7.21).Closes #160010
Based on Tiago's PR #161311.
Checklist